Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298983002: Move GrTBatchTesselator to its own file (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrTBatchTesselator to its own file BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ad37be2b1f596a163e889ae0282227055c6b661

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : feedback inc #

Patch Set 4 : tweaks #

Patch Set 5 : tweaks #

Patch Set 6 : feedback inc #

Patch Set 7 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -123 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 3 4 5 6 7 chunks +20 lines, -123 lines 0 comments Download
A src/gpu/batches/GrTInstanceBatch.h View 1 2 3 4 5 6 1 chunk +139 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-18 14:47:32 UTC) #2
bsalomon
https://codereview.chromium.org/1298983002/diff/20001/src/gpu/batches/GrTBatchTesselator.h File src/gpu/batches/GrTBatchTesselator.h (right): https://codereview.chromium.org/1298983002/diff/20001/src/gpu/batches/GrTBatchTesselator.h#newcode15 src/gpu/batches/GrTBatchTesselator.h:15: /* /** (I think the double * is needed ...
5 years, 4 months ago (2015-08-18 15:01:47 UTC) #3
joshualitt
feedback inc
5 years, 4 months ago (2015-08-18 15:56:12 UTC) #4
bsalomon
On 2015/08/18 15:56:12, joshualitt wrote: > feedback inc lgtm
5 years, 4 months ago (2015-08-18 16:24:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298983002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298983002/120001
5 years, 4 months ago (2015-08-18 17:07:35 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:16:03 UTC) #9
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/2ad37be2b1f596a163e889ae0282227055c6b661

Powered by Google App Engine
This is Rietveld 408576698