LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html - Issue 1298973004: Remove special wheel handling path from ScrollableArea

Side by Side Diff: LayoutTests/fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html

Issue 1298973004: Remove special wheel handling path from ScrollableArea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt » ('j') | LayoutTests/platform/mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <script>	4 <script>

5 var givenScrollTop = 2; // Only one page per event, so this should b e interpreted as 1	5 var givenScrollTop = 2; // Only one page per event, so this should b e interpreted as 1

6 var givenScrollLeft = 2;	6 var givenScrollLeft = 2;

7 var expectedScrollTop = 511; // Window is 800x600. 15 pixel scrollba rs. Scroll 87.5% of visible.

8 var expectedScrollLeft = 686;

9 var event;	7 var event;

10 var div;	8 var div;

11	9

12 window.jsTestIsAsync = true;	10 window.jsTestIsAsync = true;

13 if (window.testRunner)	11 if (window.testRunner)

14 testRunner.waitUntilDone();	12 testRunner.waitUntilDone();

15	13

16 function dispatchWheelEvent()	14 function dispatchWheelEvent()

17 {	15 {

18 document.body.addEventListener("mousewheel", mousewheelHandler, false);	16 document.body.addEventListener("mousewheel", mousewheelHandler, false);

19	17

20 if (window.eventSender) {	18 if (window.eventSender) {

21 eventSender.mouseMoveTo(100, 110);	19 eventSender.mouseMoveTo(100, 110);

22 eventSender.continuousMouseScrollBy(-window.givenScrollLeft, -window.givenScrollTop, true);	20 eventSender.continuousMouseScrollBy(-window.givenScrollLeft, -window.givenScrollTop, true);

23 }	21 }

24	22

25 setTimeout('checkOffsets();', 100);	23 setTimeout('checkOffsets();', 100);

26 }	24 }

27	25

28 function checkOffsets()	26 function checkOffsets()

29 {	27 {

30 shouldBe("document.scrollingElement.scrollTop", "window.expected ScrollTop");	28 debug("document.scrollingElement.scrollTop = " + document.scroll ingElement.scrollTop);

31 shouldBe("document.scrollingElement.scrollLeft", "window.expecte dScrollLeft");	29 debug("document.scrollingElement.scrollLeft = " + document.scrol lingElement.scrollLeft);
	bokan 2015/08/19 12:42:47 The expectation is platform dependent so we don't The expectation is platform dependent so we don't know the expected values here. Rick Byers 2015/08/19 17:33:30 Why did your CL change that though? Are you inten Show quoted text On 2015/08/19 12:42:47, bokan wrote: > The expectation is platform dependent so we don't know the expected values here. Why did your CL change that though? Are you intending to make the behavior more platform dependent? Ideally we should be setting up modes/inputs in layout tests to be platform independent (but have multiple test cases for the different behaviors possible in different platforms). bokan 2015/08/19 18:45:46 No, there's no change in the dependency on platfor Show quoted text On 2015/08/19 17:33:30, Rick Byers wrote: > On 2015/08/19 12:42:47, bokan wrote: > > The expectation is platform dependent so we don't know the expected values > here. > > Why did your CL change that though? Are you intending to make the behavior more > platform dependent? Ideally we should be setting up modes/inputs in layout > tests to be platform independent (but have multiple test cases for the different > behaviors possible in different platforms). No, there's no change in the dependency on platform, I'm just fixing the currently broken expectation (Mac has a separate expectation with a FAILing output). The problem is that the value outputted is dependent on platform so I don't think the test should be outputting PASS/FAIL (since it doesn't know what the expected value is) - I made it output the value and the platform dependent expectation tests for correctness. Rick Byers 2015/08/19 19:42:09 Sorry, I wrote this before seeing the test changes Show quoted text On 2015/08/19 18:45:46, bokan wrote: > On 2015/08/19 17:33:30, Rick Byers wrote: > > On 2015/08/19 12:42:47, bokan wrote: > > > The expectation is platform dependent so we don't know the expected values > > here. > > > > Why did your CL change that though? Are you intending to make the behavior > more > > platform dependent? Ideally we should be setting up modes/inputs in layout > > tests to be platform independent (but have multiple test cases for the > different > > behaviors possible in different platforms). > > No, there's no change in the dependency on platform, I'm just fixing the > currently broken expectation (Mac has a separate expectation with a FAILing > output). The problem is that the value outputted is dependent on platform so I > don't think the test should be outputting PASS/FAIL (since it doesn't know what > the expected value is) - I made it output the value and the platform dependent > expectation tests for correctness. Sorry, I wrote this before seeing the test changes. In general we rely on shouldBe to indicate what we really expect, and 'debug' to indicate things that can probably be blindly updated. Ideally layout tests would have a way to set or get the maxOverlapBetweenPages so we're not platform dependant, but adding that is probably overkill. What do you think about just hard-coding the expected maxOverlapBetweenPages value in the test file, using a UA string check to see if we're on Mac? Then we could have a shouldBe that would PASS on all platforms.
32 finishJSTest();	30 finishJSTest();

33 }	31 }

34	32

35 function mousewheelHandler(e)	33 function mousewheelHandler(e)

36 {	34 {

37 event = e;	35 event = e;

38 shouldBe("event.wheelDeltaY", "window.givenScrollTop * -3");	36 shouldBe("event.wheelDeltaY", "window.givenScrollTop * -3");

39 shouldBe("event.wheelDeltaX", "window.givenScrollLeft * -3");	37 shouldBe("event.wheelDeltaX", "window.givenScrollLeft * -3");

40	38

41 if (e.wheelDeltaY)	39 if (e.wheelDeltaY)

42 shouldBe("event.wheelDelta", "window.givenScrollTop * -3");	40 shouldBe("event.wheelDelta", "window.givenScrollTop * -3");

43 else	41 else

44 shouldBe("event.wheelDelta", "window.givenScrollLeft * -3");	42 shouldBe("event.wheelDelta", "window.givenScrollLeft * -3");

45 }	43 }

46 </script>	44 </script>

47 </head>	45 </head>

48	46

49 <body style="margin:0" onload="setTimeout('dispatchWheelEvent();', 100)">	47 <body style="margin:0" onload="setTimeout('dispatchWheelEvent();', 100)">

50 <div style="height:900px;width:2400px">	48 <div style="height:900px;width:2400px">

51 <div style="background-color:red;height:900px;width:1200px;position:re lative;left:0px;top:0px"></div>	49 <div style="background-color:red;height:900px;width:1200px;position:re lative;left:0px;top:0px"></div>

52 <div style="background-color:green;height:900px;width:1200px;position: relative;left:1200px;top:-900px"></div>	50 <div style="background-color:green;height:900px;width:1200px;position: relative;left:1200px;top:-900px"></div>

53 </div>	51 </div>

54 <div style="height:900px;width:2400px">	52 <div style="height:900px;width:2400px">

55 <div style="background-color:blue;height:900px;width:1200px;position:r elative;left:0px;top:0px"></div>	53 <div style="background-color:blue;height:900px;width:1200px;position:r elative;left:0px;top:0px"></div>

56 <div style="background-color:yellow;height:900px;width:1200px;position :relative;left:1200px;top:-900px"></div>	54 <div style="background-color:yellow;height:900px;width:1200px;position :relative;left:1200px;top:-900px"></div>

57 </div>	55 </div>

58 <div id="console"></div>	56 <div id="console"></div>

59 </body>	57 </body>

60 </html>	58 </html>

OLD	NEW