Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1298973004: Remove special wheel handling path from ScrollableArea (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed TODO Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 const ScrollableAreaSet* animatingScrollableAreas() const { return m_animati ngScrollableAreas.get(); } 300 const ScrollableAreaSet* animatingScrollableAreas() const { return m_animati ngScrollableAreas.get(); }
301 301
302 // With CSS style "resize:" enabled, a little resizer handle will appear at the bottom 302 // With CSS style "resize:" enabled, a little resizer handle will appear at the bottom
303 // right of the object. We keep track of these resizer areas for checking if touches 303 // right of the object. We keep track of these resizer areas for checking if touches
304 // (implemented using Scroll gesture) are targeting the resizer. 304 // (implemented using Scroll gesture) are targeting the resizer.
305 typedef HashSet<LayoutBox*> ResizerAreaSet; 305 typedef HashSet<LayoutBox*> ResizerAreaSet;
306 void addResizerArea(LayoutBox&); 306 void addResizerArea(LayoutBox&);
307 void removeResizerArea(LayoutBox&); 307 void removeResizerArea(LayoutBox&);
308 const ResizerAreaSet* resizerAreas() const { return m_resizerAreas.get(); } 308 const ResizerAreaSet* resizerAreas() const { return m_resizerAreas.get(); }
309 309
310 // This function exists for ports that need to handle wheel events manually.
311 // On Mac WebKit1 the underlying NSScrollView just does the scrolling, but o n most other platforms
312 // we need this function in order to do the scroll ourselves.
313 ScrollResult wheelEvent(const PlatformWheelEvent&);
314
315 bool shouldUseIntegerScrollOffset() const override; 310 bool shouldUseIntegerScrollOffset() const override;
316 311
317 bool isActive() const override; 312 bool isActive() const override;
318 313
319 // Override scrollbar notifications to update the AXObject cache. 314 // Override scrollbar notifications to update the AXObject cache.
320 void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override; 315 void didAddScrollbar(Scrollbar*, ScrollbarOrientation) override;
321 316
322 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter 317 // FIXME: This should probably be renamed as the 'inSubtreeLayout' parameter
323 // passed around the FrameView layout methods can be true while this returns 318 // passed around the FrameView layout methods can be true while this returns
324 // false. 319 // false.
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
864 static const unsigned visualPixelThreshold = 32 * 32; 859 static const unsigned visualPixelThreshold = 32 * 32;
865 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 860 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
866 setIsVisuallyNonEmpty(); 861 setIsVisuallyNonEmpty();
867 } 862 }
868 863
869 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 864 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
870 865
871 } // namespace blink 866 } // namespace blink
872 867
873 #endif // FrameView_h 868 #endif // FrameView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698