Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: Source/web/RemoteFrameClientImpl.cpp

Issue 1298973002: Abort forwarding remote input events when layoutObject is gone. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/RemoteFrameClientImpl.cpp
diff --git a/Source/web/RemoteFrameClientImpl.cpp b/Source/web/RemoteFrameClientImpl.cpp
index c62abde994d28073a2bed36267f2633b8c758d5d..40405eb83ea2bbc3915130668038167f44584744 100644
--- a/Source/web/RemoteFrameClientImpl.cpp
+++ b/Source/web/RemoteFrameClientImpl.cpp
@@ -123,6 +123,12 @@ unsigned RemoteFrameClientImpl::backForwardLength()
// process. See http://crbug.com/339659.
void RemoteFrameClientImpl::forwardInputEvent(Event* event)
{
+ // It is possible for an event to cause the remote iframe element to be
+ // hidden, which destroys the layout object. In that case we do not
+ // forward. See https://crbug.com/520705.
dcheng 2015/08/18 17:44:19 I don't think I followed the explanation in the bu
kenrb 2015/08/19 15:53:51 Comment expanded.
+ if (!toCoreFrame(m_webFrame)->ownerLayoutObject())
+ return;
+
// This is only called when we have out-of-process iframes, which
// need to forward input events across processes.
// FIXME: Add a check for out-of-process iframes enabled.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698