Abort forwarding remote input events when layoutObject is gone.

Abort forwarding remote input events when layoutObject is gone.

It is possible for an input event that will be forwarded to a remote
frame to also cause the iframe element in the local renderer to become
hidden, which destroys the layoutObject for that element. This was
causing a crash because the forwarding code requires a layoutObject for
mouse event conversion.

This patch causes event forwarding to abort in that situation.

No test because we don't yet have layout tests running with
--site-per-process.

BUG=520705
R=dcheng@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200904

[dcheng, 2015-08-18 17:44:19]

https://codereview.chromium.org/1298973002/diff/1/Source/web/RemoteFrameClien...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1298973002/diff/1/Source/web/RemoteFrameClien...
Source/web/RemoteFrameClientImpl.cpp:128: // forward. See
https://crbug.com/520705.
I don't think I followed the explanation in the bug. Would you be able to
explain this in more detail? VC or expanding the comment would be helpful, since
we don't have a layout test.

[kenrb, 2015-08-19 15:53:51]

https://codereview.chromium.org/1298973002/diff/1/Source/web/RemoteFrameClien...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1298973002/diff/1/Source/web/RemoteFrameClien...
Source/web/RemoteFrameClientImpl.cpp:128: // forward. See
https://crbug.com/520705.
On 2015/08/18 17:44:19, dcheng wrote:
> I don't think I followed the explanation in the bug. Would you be able to
> explain this in more detail? VC or expanding the comment would be helpful,
since
> we don't have a layout test.

Comment expanded.

[dcheng, 2015-08-19 16:28:10]

lgtm with some suggestions on comment wording

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:126: // It is possible for an event to
cause the remote iframe element to be
an event => a platform event

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:127: // hidden, which destroys the layout
object (for instance, a MouseOver
for instance, a mouse event that moves between elements will trigger a mouseout
on the old element, which might hide the new element

[kenrb, 2015-08-19 20:34:11]

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
File Source/web/RemoteFrameClientImpl.cpp (right):

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:126: // It is possible for an event to
cause the remote iframe element to be
On 2015/08/19 16:28:10, dcheng wrote:
> an event => a platform event

Done.

https://codereview.chromium.org/1298973002/diff/20001/Source/web/RemoteFrameC...
Source/web/RemoteFrameClientImpl.cpp:127: // hidden, which destroys the layout
object (for instance, a MouseOver
On 2015/08/19 16:28:10, dcheng wrote:
> for instance, a mouse event that moves between elements will trigger a
mouseout
> on the old element, which might hide the new element

Done.

[kenrb, 2015-08-19 20:34:14]

The CQ bit was checked by kenrb@chromium.org

[kenrb, 2015-08-19 20:34:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1298973002/#ps40001
(title: "Comments addressed")

[commit-bot: I haz the power, 2015-08-19 20:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298973002/40001

[commit-bot: I haz the power, 2015-08-19 22:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 22:22:36]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kenrb, 2015-08-20 13:50:02]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2015-08-20 13:50:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298973002/40001

[commit-bot: I haz the power, 2015-08-20 14:48:52]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200904