Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1298943003: asan: Bypass the “nearby PC” check (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

asan: Bypass the “nearby PC” check Under asan, there are many more instructions than without. The “nearby PC” check is much less useful, and would likely fail. TEST=crashpad_client_test CaptureContext.CaptureContext R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3b6e5613cb99c1695720fbc09570d75b36f32ca4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M client/capture_context_mac_test.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-19 22:31:23 UTC) #2
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-19 22:33:51 UTC) #3
Mark Mentovai
5 years, 4 months ago (2015-08-19 22:50:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b6e5613cb99c1695720fbc09570d75b36f32ca4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698