Issue 129893002: Rename ICU NaCl targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129893002: Rename ICU NaCl targets (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov

Modified:
6 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46

Visibility:
Public.

Rename ICU NaCl targets Use _nacl suffix for NaCl targets instead of _untrusted. R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243949

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -117 lines)			Patch
M	README.chromium	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	icu_nacl.gyp	View		5 chunks	+8 lines, -8 lines	0 comments	Download
D	icu_untrusted.gyp	View		1 chunk	+0 lines, -108 lines	0 comments	Download

Total messages: 5 (0 generated)

Mark Mentovai

LGTM. But also update README.chromium. It mentions icu_untrusted by name.

6 years, 11 months ago (2014-01-09 16:41:40 UTC) #2

Sergey Ulanov

On 2014/01/09 16:41:40, Mark Mentovai wrote: > LGTM. But also update README.chromium. It mentions icu_untrusted ...

6 years, 11 months ago (2014-01-09 19:17:25 UTC) #3

Sergey Ulanov

Committed patchset #2 manually as r243949 (presubmit successful).

6 years, 11 months ago (2014-01-09 19:17:39 UTC) #4

Message was sent while issue was closed.

Thanks!