Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: net/spdy/spdy_http_utils_unittest.cc

Issue 12989038: [SPDY] Remove some setters in SpdyStream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed DISALLOW_COPY_AND_ASSIGN again Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_http_utils.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_utils_unittest.cc
diff --git a/net/spdy/spdy_http_utils_unittest.cc b/net/spdy/spdy_http_utils_unittest.cc
index 5e299a9750a82a1ce09497cca2a55f0c86ab5667..b198808c9b1a7ec3f49578ea0b228ef389cacf97 100644
--- a/net/spdy/spdy_http_utils_unittest.cc
+++ b/net/spdy/spdy_http_utils_unittest.cc
@@ -4,11 +4,12 @@
#include "net/spdy/spdy_http_utils.h"
-#include "testing/platform_test.h"
+#include "base/basictypes.h"
+#include "testing/gtest/include/gtest/gtest.h"
namespace net {
-namespace test {
+namespace {
TEST(SpdyHttpUtilsTest, ConvertRequestPriorityToSpdy2Priority) {
EXPECT_EQ(0, ConvertRequestPriorityToSpdyPriority(HIGHEST, 2));
@@ -17,6 +18,7 @@ TEST(SpdyHttpUtilsTest, ConvertRequestPriorityToSpdy2Priority) {
EXPECT_EQ(2, ConvertRequestPriorityToSpdyPriority(LOWEST, 2));
EXPECT_EQ(3, ConvertRequestPriorityToSpdyPriority(IDLE, 2));
}
+
TEST(SpdyHttpUtilsTest, ConvertRequestPriorityToSpdy3Priority) {
EXPECT_EQ(0, ConvertRequestPriorityToSpdyPriority(HIGHEST, 3));
EXPECT_EQ(1, ConvertRequestPriorityToSpdyPriority(MEDIUM, 3));
@@ -25,6 +27,31 @@ TEST(SpdyHttpUtilsTest, ConvertRequestPriorityToSpdy3Priority) {
EXPECT_EQ(4, ConvertRequestPriorityToSpdyPriority(IDLE, 3));
}
+TEST(SpdyHttpUtilsTest, ConvertSpdy2PriorityToRequestPriority) {
+ EXPECT_EQ(HIGHEST, ConvertSpdyPriorityToRequestPriority(0, 2));
+ EXPECT_EQ(MEDIUM, ConvertSpdyPriorityToRequestPriority(1, 2));
+ EXPECT_EQ(LOW, ConvertSpdyPriorityToRequestPriority(2, 2));
+ EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(3, 2));
+ // These are invalid values, but we should still handle them
+ // gracefully.
+ for (int i = 4; i < kuint8max; ++i) {
+ EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(i, 2));
+ }
+}
+
+TEST(SpdyHttpUtilsTest, ConvertSpdy3PriorityToRequestPriority) {
+ EXPECT_EQ(HIGHEST, ConvertSpdyPriorityToRequestPriority(0, 3));
+ EXPECT_EQ(MEDIUM, ConvertSpdyPriorityToRequestPriority(1, 3));
+ EXPECT_EQ(LOW, ConvertSpdyPriorityToRequestPriority(2, 3));
+ EXPECT_EQ(LOWEST, ConvertSpdyPriorityToRequestPriority(3, 3));
+ EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(4, 3));
+ // These are invalid values, but we should still handle them
+ // gracefully.
+ for (int i = 5; i < kuint8max; ++i) {
+ EXPECT_EQ(IDLE, ConvertSpdyPriorityToRequestPriority(i, 3));
+ }
+}
+
TEST(SpdyHttpUtilsTest, ShowHttpHeaderValue){
#if defined(SPDY_PROXY_AUTH_ORIGIN)
EXPECT_FALSE(ShouldShowHttpHeaderValue("proxy-authorization"));
@@ -35,6 +62,6 @@ TEST(SpdyHttpUtilsTest, ShowHttpHeaderValue){
#endif
}
-} // namespace test
+} // namespace
} // namespace net
« no previous file with comments | « net/spdy/spdy_http_utils.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698