[SPDY] Remove some setters in SpdyStream

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 538 matching lines @@
         PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION);
     CloseSessionOnError(
         static_cast<net::Error>(certificate_error_code_),
         true,
         "Tried to create SPDY stream for secure content over an "
         "unauthenticated session.");
     return ERR_SPDY_PROTOCOL_ERROR;
   }
 
   const std::string& path = request.url().PathForRequest();
-
-  *stream = new SpdyStream(this, false, request.net_log());
-
-  (*stream)->set_priority(request.priority());
-  (*stream)->set_path(path);
-  (*stream)->set_send_window_size(stream_initial_send_window_size_);
-  (*stream)->set_recv_window_size(stream_initial_recv_window_size_);
+  *stream = new SpdyStream(this, path, request.priority(),
+                           stream_initial_send_window_size_,
+                           stream_initial_recv_window_size_,
+                           false, request.net_log());
   created_streams_.insert(*stream);
 
   UMA_HISTOGRAM_CUSTOM_COUNTS(
       "Net.SpdyPriorityCount",
       static_cast<int>(request.priority()), 0, 10, 11);
 
   // TODO(mbelshe): Optimize memory allocations
 
   return OK;
 }
@@ skipping 350 matching lines @@
                    weak_factory_.GetWeakPtr()));
     return ERR_IO_PENDING;
   }
 
   CHECK(connection_.get());
   CHECK(connection_->socket());
   state_ = STATE_DO_READ_COMPLETE;
   return connection_->socket()->Read(
       read_buffer_.get(),
       kReadBufferSize,
-      base::Bind(&SpdySession::OnReadComplete, base::Unretained(this)));
+      base::Bind(&SpdySession::OnReadComplete, weak_factory_.GetWeakPtr()));
 }
 
 int SpdySession::DoReadComplete(int result) {
   // Parse a frame.  For now this code requires that the frame fit into our
   // buffer (32KB).
   // TODO(mbelshe): support arbitrarily large frames!
 
   if (result <= 0) {
     // Session is tearing down.
     net::Error error = static_cast<net::Error>(result);
@@ skipping 125 matching lines @@
 
       in_flight_write_ = *buffer;
     } else {
       DCHECK(in_flight_write_.buffer()->BytesRemaining());
     }
 
     write_pending_ = true;
     int rv = connection_->socket()->Write(
         in_flight_write_.buffer(),
         in_flight_write_.buffer()->BytesRemaining(),
-        base::Bind(&SpdySession::OnWriteComplete, base::Unretained(this)));
+        base::Bind(&SpdySession::OnWriteComplete, weak_factory_.GetWeakPtr()));
     if (rv == net::ERR_IO_PENDING)
       break;
 
     // We sent the frame successfully.
     OnWriteComplete(rv);
 
     // TODO(mbelshe):  Test this error case.  Maybe we should mark the socket
     //                 as in an error state.
     if (rv < 0)
       break;
@@ skipping 454 matching lines @@
   }
 
   // There should not be an existing pushed stream with the same path.
   PushedStreamMap::iterator it = unclaimed_pushed_streams_.find(url);
   if (it != unclaimed_pushed_streams_.end()) {
     ResetStream(stream_id, RST_STREAM_PROTOCOL_ERROR,
                 "Received duplicate pushed stream with url: " + url);
     return;
   }
 
-  scoped_refptr<SpdyStream> stream(new SpdyStream(this, true, net_log_));
+  RequestPriority request_priority =
+      ConvertSpdyPriorityToRequestPriority(priority, GetProtocolVersion());
+  scoped_refptr<SpdyStream> stream(
+      new SpdyStream(this, gurl.PathForRequest(), request_priority,
+                     stream_initial_send_window_size_,
+                     stream_initial_recv_window_size_,
+                     true, net_log_));
   stream->set_stream_id(stream_id);
 
-  stream->set_path(gurl.PathForRequest());
-  stream->set_send_window_size(stream_initial_send_window_size_);
-  stream->set_recv_window_size(stream_initial_recv_window_size_);
-
   DeleteExpiredPushedStreams();
   unclaimed_pushed_streams_[url] =
       std::pair<scoped_refptr<SpdyStream>, base::TimeTicks> (
           stream, time_func_());
 
 
   ActivateStream(stream);
   stream->set_response_received();
 
   // Parse the headers.
@@ skipping 729 matching lines @@
   }
 
   session_recv_window_size_ -= delta_window_size;
   net_log_.AddEvent(
       NetLog::TYPE_SPDY_SESSION_UPDATE_RECV_WINDOW,
       base::Bind(&NetLogSpdySessionWindowUpdateCallback,
                  -delta_window_size, session_recv_window_size_));
 }
 
 }  // namespace net