Issue 12989030: SkDrawCommand cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12989030: SkDrawCommand cleanup (Closed)

Created:
7 years, 9 months ago by robertphillips

Modified:
7 years, 9 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This should be the last batch of these. This CL makes the debug canvas resilient to having its underlying SkPicture deleted out from under it (as is done in the debugger's SaveAs functionality). This remaining set of ops do not seem to appear in the captured skps.

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -127 lines)			Patch
	M	debugger/SkDrawCommand.h	View		13 chunks	+66 lines, -34 lines	0 comments	Download
	M	debugger/SkDrawCommand.cpp	View		7 chunks	+154 lines, -93 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

committed as r8355

Expand Messages | Collapse Messages