src/api.h - Issue 12989019: Put zapping of local handles behind the extra checks flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.h

Issue 12989019: Put zapping of local handles behind the extra checks flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Jakob Kummerow. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.h

diff --git a/src/api.h b/src/api.h

index 8628b2a960a020b5c111caa90c3d8f2e595581ed..d73646d99d668ec2a7ca6ea08e7a5a367b26867e 100644

--- a/src/api.h

+++ b/src/api.h

@@ -572,8 +572,8 @@ void HandleScopeImplementer::DeleteExtensions(internal::Object** prev_limit) {

#endif

blocks_.RemoveLast();

-#ifdef DEBUG

- v8::ImplementationUtilities::ZapHandleRange(block_start, block_limit);

+#ifdef ENABLE_EXTRA_CHECKS

+ internal::HandleScope::ZapRange(block_start, block_limit);

#endif

if (spare_ != NULL) {

DeleteArray(spare_);

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »