Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: media/base/video_decoder.h

Issue 12989009: Remove reference counting from media::VideoDecoder and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index 904a6fd97823e25b691df209c8c1675da92da9cd..80700b9e503666fe8206de7a51f8f29150c1f9c7 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -16,8 +16,7 @@ namespace media {
class DemuxerStream;
class VideoFrame;
-class MEDIA_EXPORT VideoDecoder
- : public base::RefCountedThreadSafe<VideoDecoder> {
+class MEDIA_EXPORT VideoDecoder {
public:
// Status codes for read operations on VideoDecoder.
enum Status {
@@ -26,6 +25,9 @@ class MEDIA_EXPORT VideoDecoder
kDecryptError // Decrypting error happened.
};
+ VideoDecoder();
+ virtual ~VideoDecoder();
+
// Initializes a VideoDecoder with the given DemuxerStream, executing the
// |status_cb| upon completion.
// |statistics_cb| is used to update the global pipeline statistics.
@@ -75,11 +77,7 @@ class MEDIA_EXPORT VideoDecoder
// use a fixed set of VideoFrames for decoding.
virtual bool HasOutputFrameAvailable() const;
- protected:
- friend class base::RefCountedThreadSafe<VideoDecoder>;
- virtual ~VideoDecoder();
- VideoDecoder();
-
+ private:
DISALLOW_COPY_AND_ASSIGN(VideoDecoder);
};

Powered by Google App Engine
This is Rietveld 408576698