Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1298893002: Update TestExpectation to suppress flakiness (Closed)

Created:
5 years, 4 months ago by kochi
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, hayato
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Update TestExpectation to suppress flakiness As found while investigating crbug.com/503445, crash by assertion hit may induce other innocent tests to crash (to be precise, look like a crash) when an used object is collected by the garbage collector and hit an assertion. I've run independent tests repeatedly to identify which tests causes similar failures and assigned bug for each. They crash anyway, so they must be fixed, but to prevent other innocent tests from crashing, mark them as "Skip" rather than "Crash". BUG=503445, 505364, 520616, 521907, 521913, 521914, 521918, 521929, 521936, 521937, 521941 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298893002/1
5 years, 4 months ago (2015-08-18 08:44:51 UTC) #2
kochi
tkent-san, Could you review?
5 years, 4 months ago (2015-08-18 08:45:43 UTC) #4
tkent
lgtm
5 years, 4 months ago (2015-08-18 08:53:20 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94534)
5 years, 4 months ago (2015-08-18 11:56:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298893002/1
5 years, 4 months ago (2015-08-19 00:54:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 01:33:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200775

Powered by Google App Engine
This is Rietveld 408576698