Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298843002: Oilpan: Fix compile after r200678. (Closed)

Created:
5 years, 4 months ago by Yuta Kitamura
Modified:
5 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/inspector/V8DebuggerAgent.h View 2 chunks +4 lines, -1 line 2 comments Download
M Source/core/inspector/V8DebuggerAgent.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yuta Kitamura
5 years, 4 months ago (2015-08-18 02:41:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298843002/1
5 years, 4 months ago (2015-08-18 02:41:21 UTC) #3
haraken
LGTM
5 years, 4 months ago (2015-08-18 02:42:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200688
5 years, 4 months ago (2015-08-18 04:23:22 UTC) #5
yurys
https://codereview.chromium.org/1298843002/diff/1/Source/core/inspector/V8DebuggerAgent.h File Source/core/inspector/V8DebuggerAgent.h (right): https://codereview.chromium.org/1298843002/diff/1/Source/core/inspector/V8DebuggerAgent.h#newcode42 Source/core/inspector/V8DebuggerAgent.h:42: : public NoBaseWillBeGarbageCollectedFinalized<V8DebuggerAgent> This class is going to be ...
5 years, 4 months ago (2015-08-18 18:45:55 UTC) #6
haraken
5 years, 4 months ago (2015-08-18 23:50:28 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1298843002/diff/1/Source/core/inspector/V8Deb...
File Source/core/inspector/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1298843002/diff/1/Source/core/inspector/V8Deb...
Source/core/inspector/V8DebuggerAgent.h:42: : public
NoBaseWillBeGarbageCollectedFinalized<V8DebuggerAgent>
On 2015/08/18 18:45:55, yurys wrote:
> This class is going to be moved out of Blink and cannot depend on Oilpan. Can
we
> start removing such dependencies now to avoid double work of first adding
Oilpan
> support for them just to remove it later?

I'm fine with it as long as you don't break oilpan builds. We had to land this
CL to fix the breakage.

Powered by Google App Engine
This is Rietveld 408576698