Issue 1298833002: Revert[8] "move some public headers into private"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1298833002: Revert[8] "move some public headers into private" (Closed)

Created:
5 years, 4 months ago by reed2

Modified:
5 years, 4 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert[8] "move some public headers into private" This reverts commit fb28cd2b13d76c324570341e1155aaadc1b532b6. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/95dd17737d0fa0401782f7fa72e5d69bb5686f67

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -659 lines)			Patch
M	gyp/animator.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/core.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	gyp/sfnt.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	include/core/SkEndian.h	View	1 chunk	+0 lines, -194 lines	0 comments	Download
D	include/core/SkFloatBits.h	View	1 chunk	+0 lines, -132 lines	0 comments	Download
D	include/core/SkFloatingPoint.h	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	include/core/SkPicture.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkScalar.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkTypeface.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	include/core/SkWeakRefCnt.h	View	1 chunk	+0 lines, -159 lines	0 comments	Download
A +	include/private/SkFloatBits.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	include/private/SkFloatingPoint.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	include/private/SkWeakRefCnt.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	include/svg/parser/SkSVGParser.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	src/core/SkEndian.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298833002/1

5 years, 4 months ago (2015-08-18 01:22:31 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-18 01:29:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/95dd17737d0fa0401782f7fa72e5d69bb5686f67

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages