Issue 129883002: Add ClassMirror.isAbstract to the API and VM implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129883002: Add ClassMirror.isAbstract to the API and VM implementation. (Closed)

Created:
6 years, 11 months ago by rmacnak

Modified:
6 years, 11 months ago

Reviewers:
gbracha, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add ClassMirror.isAbstract to the API and VM implementation. BUG=http://dartbug.com/12826 R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=31643

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -5 lines)			Patch
M	runtime/lib/mirrors.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1	4 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/lib/mirrors/abstract_class_test.dart	View		1 chunk	+169 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

rmacnak

Added missing stub for isAbstract to JsMixinApplication caught by (oddly enough) mirrors_used_test. Added test coverage ...

6 years, 11 months ago (2014-01-09 00:06:23 UTC) #1

rmacnak

6 years, 11 months ago (2014-01-09 01:27:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31643 (presubmit successful).