Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298823003: Move isRenderedCharacter() to EditorCommand.cpp from Position.cpp (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move isRenderedCharacter() to EditorCommand.cpp from Position.cpp This patch moves |isRenderedCharacter()| to "EditorCommand.cpp" from "Position.cpp" to narrow visibility of |isRenderedCharacter()| for improving code health, since it is used only classes derived from |EditorCommand|. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200891

Patch Set 1 : 2015-08-19T15:45:51 Move to VisibleUnits.cpp #

Patch Set 2 : 2015-08-19T17:30:15 Move to EditCommand.cpp #

Patch Set 3 : 2015-08-20T14:16:30 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M Source/core/editing/Position.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/editing/commands/EditCommand.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/editing/commands/EditCommand.cpp View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/1
5 years, 4 months ago (2015-08-19 06:48:00 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 07:16:45 UTC) #4
yoichio
isRenderedCharacter() is used only in EditCommand subclasses. For narrowing and improve code health, how about ...
5 years, 4 months ago (2015-08-19 08:00:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 08:19:25 UTC) #7
yosin_UTC9
On 2015/08/19 08:00:03, yoichio wrote: > isRenderedCharacter() is used only in EditCommand subclasses. > For ...
5 years, 4 months ago (2015-08-19 08:31:34 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/20001
5 years, 4 months ago (2015-08-19 12:59:37 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/41565)
5 years, 4 months ago (2015-08-19 14:40:02 UTC) #12
yoichio
lgtm
5 years, 4 months ago (2015-08-20 02:00:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/20001
5 years, 4 months ago (2015-08-20 04:22:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90432)
5 years, 4 months ago (2015-08-20 04:26:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/40001
5 years, 4 months ago (2015-08-20 05:17:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/22150)
5 years, 4 months ago (2015-08-20 05:48:10 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/40001
5 years, 4 months ago (2015-08-20 06:07:56 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110845)
5 years, 4 months ago (2015-08-20 07:02:08 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/40001
5 years, 4 months ago (2015-08-20 07:07:26 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110876)
5 years, 4 months ago (2015-08-20 08:02:30 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298823003/40001
5 years, 4 months ago (2015-08-20 08:17:45 UTC) #32
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 09:25:35 UTC) #33
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200891

Powered by Google App Engine
This is Rietveld 408576698