Clean up BUILD_simulator.py

Clean up BUILD_simulator.py

Committed: https://skia.googlesource.com/skia/+/bf3dde2716e26aebd789df2e7d41f5435ac928c4

[hal.canary, 2015-08-17 22:25:32]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-08-17 22:40:34]

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py
File tools/BUILD_simulator.py (right):

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py#ne...
tools/BUILD_simulator.py:30: # Python code.  This pulls its variable definitions
(SRCS, HDRS, DEFINES, etc.)
Update all the comments when we're settled?

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py#ne...
tools/BUILD_simulator.py:33: execfile('BUILD.public', globals(),
local_namespace)
Let's do this:

from pprint import pprint
from glob import glob

def noop(*args, **kwargs):
  pass

def BUILD_glob(include, exclude=()):
  ...

global = {
  'exports_files': noop,
  'glob': BUILD_glob,
}
local = {}
execfile('BUILD.public', global, local)
...
for name, value in sorted(local.items()):
   ...

[hal.canary, 2015-08-18 15:14:23]

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py
File tools/BUILD_simulator.py (right):

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py#ne...
tools/BUILD_simulator.py:30: # Python code.  This pulls its variable definitions
(SRCS, HDRS, DEFINES, etc.)
On 2015/08/17 22:40:34, mtklein wrote:
> Update all the comments when we're settled?

Done.

https://codereview.chromium.org/1298813002/diff/1/tools/BUILD_simulator.py#ne...
tools/BUILD_simulator.py:33: execfile('BUILD.public', globals(),
local_namespace)
On 2015/08/17 22:40:34, mtklein wrote:
> Let's do this:
> [...]
> global = {
> [...]

global is a keyword.  Otherwise, done.

[hal.canary, 2015-08-18 15:27:04]

done

[mtklein, 2015-08-18 15:28:58]

lgtm

[hal.canary, 2015-08-18 15:29:27]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-08-18 15:29:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298813002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298813002/60001

[commit-bot: I haz the power, 2015-08-18 15:35:47]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bf3dde2716e26aebd789df2e7d41f5435ac928c4