Issue 1298803003: Fixed two bugs related to OOPIFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1298803003: Fixed two bugs related to OOPIFs (Closed)

Created:
5 years, 4 months ago by sky

Modified:
5 years, 4 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fixed two bugs related to OOPIFs . FocusController::setFocusedElement() assumes the focusedFrame() is local. . ChromeClientImpl assumes webview client is non-null. BUG=522260 TEST=none R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200766

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/page/FocusController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/web/ChromeClientImpl.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nate Chapin

lgtm. Could we get some crashed report links or stack traces in the bug?

5 years, 4 months ago (2015-08-18 22:10:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298803003/1

5 years, 4 months ago (2015-08-18 22:11:37 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-18 23:29:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200766

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages