Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.cc

Issue 12988003: [Android] Fix remaining linker errors for components build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: unexported URLRequestJobManager Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/native/webview_native.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/net/aw_url_request_job_factory.cc
diff --git a/android_webview/browser/net/aw_url_request_job_factory.cc b/android_webview/browser/net/aw_url_request_job_factory.cc
index c14cd17b97ac9609bc676ffb21a5e909e9aae425..2aad486a0a863aedae4393912ebb0b4306483861 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.cc
+++ b/android_webview/browser/net/aw_url_request_job_factory.cc
@@ -47,10 +47,9 @@ URLRequestJob* AwURLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
if (job)
return job;
- // If the URLRequestJobManager supports the scheme NULL should be returned
- // from this method. In that case the built in handlers in
- // URLRequestJobManager will then be used to create the job.
- if (net::URLRequestJobManager::GetInstance()->SupportsScheme(scheme))
+ // If URLRequest supports the scheme NULL should be returned from this method.
+ // In that case the built in handlers will then be used to create the job.
joth 2013/03/27 20:33:19 this comment add "see the ASSUMPTION in IsHandledP
Yaron 2013/03/27 21:18:53 Done.
+ if (net::URLRequest::IsHandledProtocol(scheme))
return NULL;
return new net::URLRequestErrorJob(
« no previous file with comments | « no previous file | android_webview/native/webview_native.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698