add virtual SkTypeface::onOpenStream and override that for fontconfig

add virtual SkTypeface::onOpenStream and override that for fontconfig
(other ports to follow)

When this is complete, we will be able to remove from SkFontHost
- OpenStream
- GetFileName
Committed: https://code.google.com/p/skia/source/detail?r=8299

[reed1, 2013-03-21 18:12:41]

patch #2 adds dox for openStream()

[bungeman-skia, 2013-03-21 18:16:02]

lgtm

https://codereview.chromium.org/12988002/diff/1/trunk/include/core/SkTypeface.h
File trunk/include/core/SkTypeface.h (right):

https://codereview.chromium.org/12988002/diff/1/trunk/include/core/SkTypeface...
trunk/include/core/SkTypeface.h:216: virtual SkStream* onOpenStream(int*
ttcIndex) const;
Maybe this is already implied, but doc-ing that ttcIndex is an (optional) out
parameter would be nice. It makes it clearer that you're going to get a full
stream *and also* the ttc index of the typeface. (Though this is actually a
comment on the more public facing part, it would also be nice to be sure this is
documented so that SkTypeface implementors know all of this.)

https://codereview.chromium.org/12988002/diff/1/trunk/src/core/SkTypeface.cpp
File trunk/src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/12988002/diff/1/trunk/src/core/SkTypeface.cpp...
trunk/src/core/SkTypeface.cpp:128: // do our subclasses don't need to check for
null param
s/do/so ?

[reed1, 2013-03-21 18:18:08]

https://codereview.chromium.org/12988002/diff/1/trunk/include/core/SkTypeface.h
File trunk/include/core/SkTypeface.h (right):

https://codereview.chromium.org/12988002/diff/1/trunk/include/core/SkTypeface...
trunk/include/core/SkTypeface.h:216: virtual SkStream* onOpenStream(int*
ttcIndex) const;
On 2013/03/21 18:16:02, bungeman1 wrote:
> Maybe this is already implied, but doc-ing that ttcIndex is an (optional) out
> parameter would be nice. It makes it clearer that you're going to get a full
> stream *and also* the ttc index of the typeface. (Though this is actually a
> comment on the more public facing part, it would also be nice to be sure this
is
> documented so that SkTypeface implementors know all of this.)

Done.

https://codereview.chromium.org/12988002/diff/1/trunk/src/core/SkTypeface.cpp
File trunk/src/core/SkTypeface.cpp (right):

https://codereview.chromium.org/12988002/diff/1/trunk/src/core/SkTypeface.cpp...
trunk/src/core/SkTypeface.cpp:128: // do our subclasses don't need to check for
null param
On 2013/03/21 18:16:02, bungeman1 wrote:
> s/do/so ?

Done.

[reed1, 2013-03-21 18:22:06]

Committed patchset #3 manually as r8299 (presubmit successful).