Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1298783003: Move rpath ldflags under is_component_build (Closed)

Created:
5 years, 4 months ago by Bons
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move rpath ldflags under is_component_build The shared library flags currently being passed should only be passed in component builds. The location of dylibs in a non-component build is already known so it’s superfluous to specify additional search paths via rpath. -search_paths_first is the default on ld starting with the Xcode4 toolchain. -L. isn’t needed since the absolute path of the dylib is being specified at link time. R=mark,dpranke,thakis BUG=345021 Committed: https://crrev.com/465929bd9eccfd0de10965867e0378eee4a24dd5 Cr-Commit-Position: refs/heads/master@{#343793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M build/config/mac/BUILD.gn View 1 chunk +11 lines, -9 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Bons
5 years, 4 months ago (2015-08-17 22:31:40 UTC) #2
Mark Mentovai
I’m not competent to review .gn but I am competent to say that the change ...
5 years, 4 months ago (2015-08-17 22:34:44 UTC) #3
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-18 01:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298783003/1
5 years, 4 months ago (2015-08-18 01:47:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 02:15:28 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 02:16:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465929bd9eccfd0de10965867e0378eee4a24dd5
Cr-Commit-Position: refs/heads/master@{#343793}

Powered by Google App Engine
This is Rietveld 408576698