Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: components/crash_keys.gypi

Issue 1298743002: Partially componentize chrome/common/crash_keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation on iOS Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash_keys.gypi
diff --git a/components/toolbar.gypi b/components/crash_keys.gypi
similarity index 55%
copy from components/toolbar.gypi
copy to components/crash_keys.gypi
index 77dc03909b459acaa06f46cf338bb82c19ab881f..5baf2eb46eb967513e578c7cff222905774ffce8 100644
--- a/components/toolbar.gypi
+++ b/components/crash_keys.gypi
@@ -5,20 +5,20 @@
{
'targets': [
{
- # GN version: //components/toolbar
- 'target_name': 'toolbar',
+ # GN version: //components/crash_keys
+ 'target_name': 'crash_keys',
'type': 'static_library',
- 'dependencies': [
- '../base/base.gyp:base',
- '../url/url.gyp:url_lib',
- ],
'include_dirs': [
'..',
],
+ 'dependencies': [
+ # List of dependencies is intentionally very minimal. Please avoid
+ # adding extra dependencies without first checking with OWNERS.
+ '../base/base.gyp:base',
+ ],
'sources': [
- # Note: sources list duplicated in GN build.
- 'toolbar/toolbar_model.cc',
- 'toolbar/toolbar_model.h',
+ 'crash_keys/crash_keys.cc',
+ 'crash_keys/crash_keys.h',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698