Partially componentize chrome/common/crash_keys.

Partially componentize chrome/common/crash_keys.

Create a new component crash_keys and move there all the free functions
and constants that are used by iOS so that the code can be shared.

Do not move the key registration into the component as the list of keys
that can be used depends on the embedder.

Provides an iOS specific key registration method.

BUG=520968
Committed: https://crrev.com/a7434334176b476cf1a06ce84abe2dcc2a2cb652
Cr-Commit-Position: refs/heads/master@{#344256}

[sdefresne, 2015-08-17 16:55:29]

Patchset #1 (id:1) has been deleted

[sdefresne, 2015-08-17 16:57:16]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org, rsesek@chromium.org, sky@chromium.org

[sdefresne, 2015-08-17 16:57:17]

rsesek: please review new component and chrome/common/crash_keys.*

sky: please review //chrome changes as OWNERS

mark: please review new dependency of //ios/chrome on //breakpad/src/common

[sdefresne, 2015-08-17 17:29:59]

Patchset #2 (id:40001) has been deleted

[sdefresne, 2015-08-17 17:30:03]

Patchset #1 (id:20001) has been deleted

[sky, 2015-08-17 18:06:00]

LGTM

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_tests_uni...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_tests_uni...
chrome/chrome_tests_unit.gypi:2741: '../components/components.gyp:crash_keys',
nit: sort

[Mark Mentovai, 2015-08-17 18:55:01]

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_exe.gypi#...
chrome/chrome_exe.gypi:469: '../components/components.gyp:crash_keyes',
keys, not keyes

https://codereview.chromium.org/1298743002/diff/80001/ios/chrome/browser/cras...
File ios/chrome/browser/crash_report/crash_keys.h (right):

https://codereview.chromium.org/1298743002/diff/80001/ios/chrome/browser/cras...
ios/chrome/browser/crash_report/crash_keys.h:8: #include <cstddef>
<stddef.h>

[sdefresne, 2015-08-18 12:47:40]

Thank you for the reviews. Please take another look.

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_exe.gypi
File chrome/chrome_exe.gypi (right):

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_exe.gypi#...
chrome/chrome_exe.gypi:469: '../components/components.gyp:crash_keyes',
On 2015/08/17 at 18:55:01, Mark Mentovai - out til August wrote:
> keys, not keyes

Done.

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_tests_uni...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/1298743002/diff/80001/chrome/chrome_tests_uni...
chrome/chrome_tests_unit.gypi:2741: '../components/components.gyp:crash_keys',
On 2015/08/17 at 18:06:00, sky wrote:
> nit: sort

Done.

https://codereview.chromium.org/1298743002/diff/80001/ios/chrome/browser/cras...
File ios/chrome/browser/crash_report/crash_keys.h (right):

https://codereview.chromium.org/1298743002/diff/80001/ios/chrome/browser/cras...
ios/chrome/browser/crash_report/crash_keys.h:8: #include <cstddef>
On 2015/08/17 at 18:55:01, Mark Mentovai - out til August wrote:
> <stddef.h>

Done.

[Mark Mentovai, 2015-08-18 13:15:29]

LGTM

[Robert Sesek, 2015-08-18 14:20:16]

LGTM

This feels a bit odd to componentize, but it seems necessary.

https://codereview.chromium.org/1298743002/diff/160001/components/crash_keys/...
File components/crash_keys/DEPS (right):

https://codereview.chromium.org/1298743002/diff/160001/components/crash_keys/...
components/crash_keys/DEPS:1: # This component is shared with the Chrome OS
build, so it's important to limit
Comment seems obsolte.

[sdefresne, 2015-08-19 08:17:17]

On 2015/08/18 at 14:20:16, rsesek wrote:
> LGTM
> 
> This feels a bit odd to componentize, but it seems necessary.
> 
>
https://codereview.chromium.org/1298743002/diff/160001/components/crash_keys/...
> File components/crash_keys/DEPS (right):
> 
>
https://codereview.chromium.org/1298743002/diff/160001/components/crash_keys/...
> components/crash_keys/DEPS:1: # This component is shared with the Chrome OS
build, so it's important to limit
> Comment seems obsolte.

The opposite, it is not yet true but will soon be used on Chrome OS (as I'm
going to add a dependency on that component from components/variations that is
itself used by Chrome OS build).

[sdefresne, 2015-08-19 15:57:05]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-08-19 15:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
mark@chromium.org
Link to the patchset: https://codereview.chromium.org/1298743002/#ps160001
(title: "Fix typo (= instead of == in components/crash_keys.gypi)")

[commit-bot: I haz the power, 2015-08-19 15:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298743002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298743002/160001

[commit-bot: I haz the power, 2015-08-19 17:01:04]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2015-08-19 17:01:42]

Patchset 6 (id:??) landed as
https://crrev.com/a7434334176b476cf1a06ce84abe2dcc2a2cb652
Cr-Commit-Position: refs/heads/master@{#344256}