Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1298733003: Reland of move property loads from js builtins objects from runtime. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of move property loads from js builtins objects from runtime. (patchset #1 id:1 of https://codereview.chromium.org/1297803003/ ) Reason for revert: Debug isolate failure has nothing to do with this CL. Original issue's description: > Revert of Remove property loads from js builtins objects from runtime. (patchset #2 id:20001 of https://codereview.chromium.org/1293113002/ ) > > Reason for revert: > Still failures in debug-isolates tests > > Original issue's description: > > Remove property loads from js builtins objects from runtime. > > > > R=cbruni@chromium.org > > > > Committed: https://crrev.com/40f6e80d22d2e146b781aa661b76087ab9a492c4 > > Cr-Commit-Position: refs/heads/master@{#30199} > > > > Committed: https://crrev.com/f22d0f205031054a5f3116e052c81ae85741e8e0 > > Cr-Commit-Position: refs/heads/master@{#30209} > > TBR=cbruni@chromium.org,hpayer@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/4106a4cbb701b5fe7d0b639e28a4ebfca5c05630 > Cr-Commit-Position: refs/heads/master@{#30213} TBR=cbruni@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/8e1176a5fa09bb7c72ea85cf726fb4314cbf9ece Cr-Commit-Position: refs/heads/master@{#30215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -75 lines) Patch
M src/api.cc View 7 chunks +36 lines, -40 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +11 lines, -9 lines 0 comments Download
M src/messages.js View 7 chunks +17 lines, -21 lines 0 comments Download
M src/v8natives.js View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Reland of move property loads from js builtins objects from runtime.
5 years, 4 months ago (2015-08-18 09:55:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298733003/1
5 years, 4 months ago (2015-08-18 09:55:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 09:55:46 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 09:55:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e1176a5fa09bb7c72ea85cf726fb4314cbf9ece
Cr-Commit-Position: refs/heads/master@{#30215}

Powered by Google App Engine
This is Rietveld 408576698