Remove RenderImage::m_needsToSetSizeForAltText

Remove RenderImage::m_needsToSetSizeForAltText

Remove another user of StyleChangeFromRenderer. This code doesn't look
needed and doesn't make sense. The test that was landed with it passes
even without the code today too.

The code came from http://trac.webkit.org/changeset/72040 and the
hasPendingStyleRecalc() check comes from
http://trac.webkit.org/changeset/72135

Checking for a pending recalc like this code did is very suspect, any
number of things can cause a recalc, or schedule one later, so checking
for a pending recalc inside the ::imageChanged callback doesn't make a
lot of sense.

Removing this code also lets us remove Document::hasPendingStyleRecalc().
In doing so I also moved methods related to the style recalc machinery
to private so people will not use them.

BUG=336552
R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165553

[ojan, 2014-01-21 22:16:15]

lgtm

[commit-bot: I haz the power, 2014-01-21 22:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/129873009/1

[commit-bot: I haz the power, 2014-01-21 23:05:21]

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 00:04:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/129873009/1

[commit-bot: I haz the power, 2014-01-22 01:19:56]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 01:21:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/129873009/1

[commit-bot: I haz the power, 2014-01-22 04:37:43]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 09:38:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/129873009/1

[commit-bot: I haz the power, 2014-01-22 12:59:02]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 16:18:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/129873009/1

[commit-bot: I haz the power, 2014-01-22 20:08:06]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[esprehn, 2014-01-22 20:55:53]

Committed patchset #1 manually as r165553 (presubmit successful).