RenderBlock::isSelfCollapsingBlock() should only be used when an object does not require layout.

Source/core/rendering/RenderTextControlPlaceholder.h

 /*
- * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
- * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
+ * Copyright (C) 2014 Robert Hogan <robert@roberthogan.net>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
-#ifndef SVGDescElement_h
-#define SVGDescElement_h
+#ifndef RenderTextControlPlaceholder_h
+#define RenderTextControlPlaceholder_h
 
-#include "core/svg/SVGElement.h"
+#include "core/rendering/RenderBlockFlow.h"
 
 namespace WebCore {
 
-class SVGDescElement FINAL : public SVGElement {
+
+class RenderTextControlPlaceholder FINAL : public RenderBlockFlow {
 public:
-    static PassRefPtr<SVGDescElement> create(Document&);
+    explicit RenderTextControlPlaceholder(Element*);
+    virtual ~RenderTextControlPlaceholder();
+    virtual bool isSelfCollapsingBlock() const OVERRIDE FINAL { return false; }

[ojan, 2014/01/14 00:34:18]

I think this deserve a comment explaining why we override it.

Also, can you point me at the code that you reference in the change description
that does the parent's layout before the child?

[rhogan, 2014/01/14 19:23:01]

Yes: the placeholder is not laid out until the end of 
RenderTextControlSingleLine::layout().

+};
 
-    String description() const;
-
-private:
-    explicit SVGDescElement(Document&);
-
-    virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE { return false; }
-};
+DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTextControlPlaceholder, isTableCaption());

[ojan, 2014/01/14 00:34:18]

isTableCaption?

 
 } // namespace WebCore
 
-#endif
+#endif // RenderTextControlPlaceholder_h