Tweak ifdefs for MessageLoopForUI::Add/RemoveObserver

Tweak ifdefs for MessageLoopForUI::Add/RemoveObserver

This is necessitated by our building of base for tools. In particular
if I set OS_ANDROID and USE_AURA then the host is built with OS_LINUX
and USE_AURA, but none of the other flags we normally set if USE_AURA
is set for OS_LINUX.

And yes, I really need to spend time and refactor messageloop. It is
such a mess of ifdefs right now.

BUG=none
TEST=none
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244386

[sky, 2014-01-10 19:38:04]

A little more explanation here. When I build with os=android and use_aura that
means we get OS_ANDROID and USE_AURA set for one compile (the target) and
OS_LINUX and USE_AURA for the second compile (host). Normally when we compile
aura for linux we also set USE_X11 or USE_OZONE. But because of how the
host/target compiles are set up that doesn't happen in this case. Apparently its
a little dicey with gyp as both host and target share the same set of use_
flags. That isn't the case with gn, but is for gyp.

Either way the set of defines I'm adding here better match reality.

[darin (slow to review), 2014-01-10 19:47:49]

LGTM

[commit-bot: I haz the power, 2014-01-10 20:54:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/129873003/1

[commit-bot: I haz the power, 2014-01-10 22:06:50]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps,
check_deps2git, chromedriver_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, interactive_ui_tests, ipc_tests,
jingle_unittests, media_unittests, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests,
sandbox_linux_unittests, sql_unittests, sync_integration_tests, sync_unit_tests,
unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[sky, 2014-01-10 23:29:12]

*SIGH* I had to make the ifdef more complex for nacl, eg a specific !OS_NACL.
Since this was there before I'm going to land.

[commit-bot: I haz the power, 2014-01-11 00:21:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/129873003/330001

[darin (slow to review), 2014-01-11 00:44:47]

OK


On Fri, Jan 10, 2014 at 3:29 PM, <sky@chromium.org> wrote:

> *SIGH* I had to make the ifdef more complex for nacl, eg a specific
> !OS_NACL.
> Since this was there before I'm going to land.
>
> https://codereview.chromium.org/129873003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-11 04:23:42]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-11 15:59:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/129873003/330001

[commit-bot: I haz the power, 2014-01-11 23:12:10]

Change committed as 244386