Rip autofill code out of webdataservice

chrome/browser/webdata/autofill_web_data_service_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/autofill_web_data_service_impl.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "chrome/browser/webdata/autofill_change.h"
 #include "chrome/browser/webdata/autofill_entry.h"
@@ skipping 132 matching lines @@
   wdbs_->ScheduleDBTask(FROM_HERE,
       Bind(&AutofillWebDataServiceImpl::RemoveCreditCardImpl, this, guid));
 }
 
 AutofillWebDataServiceImpl::Handle AutofillWebDataServiceImpl::GetCreditCards(
     WebDataServiceConsumer* consumer) {
   return wdbs_->ScheduleDBTaskWithResult(FROM_HERE,
       Bind(&AutofillWebDataServiceImpl::GetCreditCardsImpl, this), consumer);
 }
 
+void AutofillWebDataServiceImpl::RemoveFormElementsAddedBetween(
+    const Time& delete_begin, const Time& delete_end) {
+  wdbs_->ScheduleDBTask(FROM_HERE,
+      Bind(&AutofillWebDataServiceImpl::RemoveFormElementsAddedBetweenImpl,
+           this, delete_begin, delete_end));
+}
+
+void
+AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetween(
+    const Time& delete_begin, const Time& delete_end) {
+  wdbs_->ScheduleDBTask(FROM_HERE, Bind(
+&AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl,

[dhollowa, 2013/03/25 21:50:38]

Gosh, this is excessive.  How would you feel about a global replace like:
s/RemoveAutofillProfilesAndCreditCardsModifiedBetween/RemoveAutofillDataModifiedBetween/
?

[Cait (Slow), 2013/03/26 14:29:23]

Done. There is a method of the same name on the AutofillTable as well, should I
update it too?

[dhollowa, 2013/03/26 15:14:09]

Yes, please.

+      this, delete_begin, delete_end));
+}
+
 AutofillWebDataServiceImpl::~AutofillWebDataServiceImpl() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // Autofill implementation.
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 WebDatabase::State AutofillWebDataServiceImpl::AddFormElementsImpl(
@@ skipping 233 matching lines @@
   std::vector<CreditCard*> credit_cards;
   AutofillTable::FromWebDatabase(db)->GetCreditCards(&credit_cards);
   return scoped_ptr<WDTypedResult>(
       new WDDestroyableResult<std::vector<CreditCard*> >(
           AUTOFILL_CREDITCARDS_RESULT,
           credit_cards,
         base::Bind(&AutofillWebDataServiceImpl::DestroyAutofillCreditCardResult,
               base::Unretained(this))));
 }
 
+WebDatabase::State
+AutofillWebDataServiceImpl::RemoveAutofillProfilesAndCreditCardsModifiedBetweenImpl(
+        const base::Time& delete_begin, const base::Time& delete_end,
+        WebDatabase* db) {
+  std::vector<std::string> profile_guids;
+  std::vector<std::string> credit_card_guids;
+  if (AutofillTable::FromWebDatabase(db)->
+      RemoveAutofillProfilesAndCreditCardsModifiedBetween(
+          delete_begin,
+          delete_end,
+          &profile_guids,
+          &credit_card_guids)) {
+    for (std::vector<std::string>::iterator iter = profile_guids.begin();
+         iter != profile_guids.end(); ++iter) {
+      AutofillProfileChange change(AutofillProfileChange::REMOVE, *iter,
+                                   NULL);
+      content::NotificationService::current()->Notify(
+          chrome::NOTIFICATION_AUTOFILL_PROFILE_CHANGED,
+          content::Source<AutofillWebDataService>(this),
+          content::Details<AutofillProfileChange>(&change));
+    }
+    // Note: It is the caller's responsibility to post notifications for any
+    // changes, e.g. by calling the Refresh() method of PersonalDataManager.
+    return WebDatabase::COMMIT_NEEDED;
+  }
+  return WebDatabase::COMMIT_NOT_NEEDED;
+}
+
 void AutofillWebDataServiceImpl::DestroyAutofillProfileResult(
     const WDTypedResult* result) {
   DCHECK(result->GetType() == AUTOFILL_PROFILES_RESULT);
   const WDResult<std::vector<AutofillProfile*> >* r =
       static_cast<const WDResult<std::vector<AutofillProfile*> >*>(result);
   std::vector<AutofillProfile*> profiles = r->GetValue();
   STLDeleteElements(&profiles);
 }
 
 void AutofillWebDataServiceImpl::DestroyAutofillCreditCardResult(
       const WDTypedResult* result) {
   DCHECK(result->GetType() == AUTOFILL_CREDITCARDS_RESULT);
   const WDResult<std::vector<CreditCard*> >* r =
       static_cast<const WDResult<std::vector<CreditCard*> >*>(result);
 
   std::vector<CreditCard*> credit_cards = r->GetValue();
   STLDeleteElements(&credit_cards);
 }