Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 12987014: Fix store_mode bug involving polymorphism with external and JS arrays. (Closed)

Created:
7 years, 9 months ago by danno
Modified:
7 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix store_mode bug involving polymorphism with external and JS arrays. Committed: http://code.google.com/p/v8/source/detail?r=14064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -11 lines) Patch
M src/ic.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/external-and-normal-array-polymorphim.js View 1 chunk +19 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
7 years, 9 months ago (2013-03-25 15:02:22 UTC) #1
Toon Verwaest
lgtm
7 years, 9 months ago (2013-03-25 15:10:08 UTC) #2
danno
7 years, 9 months ago (2013-03-25 15:19:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698