Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1298633002: [Editing] Make InsertListCommand check endingSelection() editability. (Closed)

Created:
5 years, 4 months ago by yoichio
Modified:
5 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Editing] Make InsertListCommand check endingSelection() editability. doApply assumes |endingSelection()| has rootEditableElement as L114 checks. However, reseting |endingSelection()| through |endOfSelection| at L171 can invalidate the assumption. This CL let it return early if it does. We should fix the reseting |endingSelection| algorithm in long term but let me fix the stable blocker crash. BUG=515490 TEST=LayoutTests/editing/execCommand/insert-ordered-list-crash2.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200709

Patch Set 1 : v1 #

Total comments: 2

Patch Set 2 : nit pick #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
A LayoutTests/editing/execCommand/insert-ordered-list-crash2.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
yoichio
5 years, 4 months ago (2015-08-18 01:33:52 UTC) #3
yosin_UTC9
lgtm Please update description to fin in 80 chars line. Replace This CL let => ...
5 years, 4 months ago (2015-08-18 02:05:45 UTC) #4
yoichio
Update description. Thanks https://codereview.chromium.org/1298633002/diff/20001/LayoutTests/editing/execCommand/insert-ordered-list-crash2.html File LayoutTests/editing/execCommand/insert-ordered-list-crash2.html (right): https://codereview.chromium.org/1298633002/diff/20001/LayoutTests/editing/execCommand/insert-ordered-list-crash2.html#newcode13 LayoutTests/editing/execCommand/insert-ordered-list-crash2.html:13: <div >DDD</div> On 2015/08/18 02:05:45, Yosi_UTC9 ...
5 years, 4 months ago (2015-08-18 05:46:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298633002/40001
5 years, 4 months ago (2015-08-18 05:46:38 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:13:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200709

Powered by Google App Engine
This is Rietveld 408576698