Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 129863002: Makes View::focusable() return last value supplied to SetFocusable() (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, ben+views_chromium.org, James Su
Visibility:
Public.

Description

Makes View::focusable() return last value supplied to SetFocusable() As focusable() may effect the preferred size it is important that it returns the last value passed to SetFocusable() rather than if the view is focusable right now. Otherwise focusable() could change value based on enabled or visible state, resulting in the preferred size bouncing around. I'm also making focusable() protected as it's really only subclasses that should care about it. Especially since we also have IsFocusable(). BUG=330696 TEST=covered by test R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244282

Patch Set 1 #

Patch Set 2 : fix views_examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/examples/button_example.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
6 years, 11 months ago (2014-01-08 23:48:58 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-09 04:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/129863002/200001
6 years, 11 months ago (2014-01-09 15:44:01 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244109
6 years, 11 months ago (2014-01-09 17:01:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/129863002/200001
6 years, 11 months ago (2014-01-10 18:49:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/129863002/200001
6 years, 11 months ago (2014-01-10 23:24:57 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 00:13:26 UTC) #7
Message was sent while issue was closed.
Change committed as 244282

Powered by Google App Engine
This is Rietveld 408576698