Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1298623002: [CSS Grid Layout] Implement auto-margins alignment of grid items (Closed)

Created:
5 years, 4 months ago by jfernandez
Modified:
5 years, 2 months ago
CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Grid Layout] Implement auto-margins alignment of grid items The Grid Layout spec states that we must center items with auto margins, so it will absorb any positive free space, both horiontal and vertical. https://drafts.csswg.org/css-grid/#auto-margins Besides, auto-margins imply that any alignment property in the same axis will have no effect BUG=79180, 249451, 376823 Committed: https://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87 Cr-Commit-Position: refs/heads/master@{#351796}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Don't need the resetAutoMargins function. #

Total comments: 32

Patch Set 3 : Using start/end and before/after logical terms. #

Messages

Total messages: 21 (5 generated)
jfernandez
5 years, 4 months ago (2015-08-16 22:59:09 UTC) #2
cbiesinger
https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1688 Source/core/layout/LayoutGrid.cpp:1688: child.clearOverrideLogicalContentHeight(); Why do you have this line?
5 years, 4 months ago (2015-08-17 23:50:40 UTC) #3
jfernandez
https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1688 Source/core/layout/LayoutGrid.cpp:1688: child.clearOverrideLogicalContentHeight(); On 2015/08/17 23:50:40, cbiesinger wrote: > Why do ...
5 years, 4 months ago (2015-08-24 10:28:23 UTC) #4
cbiesinger
https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1688 Source/core/layout/LayoutGrid.cpp:1688: child.clearOverrideLogicalContentHeight(); On 2015/08/24 10:28:23, jfernandez wrote: > On 2015/08/17 ...
5 years, 3 months ago (2015-08-26 23:07:45 UTC) #5
jfernandez
On 2015/08/26 23:07:45, cbiesinger wrote: > https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp > File Source/core/layout/LayoutGrid.cpp (right): > > https://codereview.chromium.org/1298623002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1688 > ...
5 years, 3 months ago (2015-08-27 08:50:53 UTC) #6
jfernandez
In (PatchSet 2) I removed the resetAutoMarginsAndLogicalTopInColumnAxis function, since now I compute margins for getting ...
5 years, 3 months ago (2015-09-11 23:43:44 UTC) #7
Manuel Rego
Non-owner LGTM. It's a pain that we've so many duplicated code shared with flexbox. It'd ...
5 years, 3 months ago (2015-09-24 11:38:27 UTC) #8
jfernandez
Replied to some of the comments. https://codereview.chromium.org/1298623002/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html File LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html (right): https://codereview.chromium.org/1298623002/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html#newcode14 LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html:14: width: -webkit-fit-content; On ...
5 years, 2 months ago (2015-09-25 13:47:02 UTC) #9
Manuel Rego
https://codereview.chromium.org/1298623002/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html File LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html (right): https://codereview.chromium.org/1298623002/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html#newcode14 LayoutTests/fast/css-grid-layout/grid-item-auto-margins-alignment.html:14: width: -webkit-fit-content; On 2015/09/25 13:47:01, jfernandez wrote: > On ...
5 years, 2 months ago (2015-09-25 16:00:59 UTC) #10
jfernandez
5 years, 2 months ago (2015-09-28 09:18:52 UTC) #11
cbiesinger
lgtm
5 years, 2 months ago (2015-09-30 14:11:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298623002/40001
5 years, 2 months ago (2015-10-01 09:37:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76349)
5 years, 2 months ago (2015-10-01 12:12:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298623002/40001
5 years, 2 months ago (2015-10-01 13:28:13 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-01 14:37:40 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 14:38:50 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68a823dcd4e9c63a0d324bc96695fd010d734d87
Cr-Commit-Position: refs/heads/master@{#351796}

Powered by Google App Engine
This is Rietveld 408576698