Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: src/objects.h

Issue 1298603002: [runtime] Unify and fix the strict equality comparison. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index c298cc86faa3012c965e5d74b360be8b32ecb1b3..a19ac5d510f689ed73a404c5f4c76cdfe640e90c 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1088,6 +1088,9 @@ class Object {
bool BooleanValue(); // ECMA-262 9.2.
+ // ES6 section 7.2.13 Strict Equality Comparison
+ bool StrictEquals(Object* that);
+
// Convert to a JSObject if needed.
// native_context is used when creating wrapper object.
static inline MaybeHandle<JSReceiver> ToObject(Isolate* isolate,
@@ -1593,6 +1596,9 @@ class Simd128Value : public HeapObject {
DECLARE_PRINTER(Simd128Value)
DECLARE_VERIFIER(Simd128Value)
+ // Equality operations.
+ inline bool Equals(Simd128Value* that);
+
// Checks that another instance is bit-wise equal.
bool BitwiseEquals(const Simd128Value* other) const;
// Computes a hash from the 128 bit value, viewed as 4 32-bit integers.
@@ -1629,6 +1635,8 @@ class Simd128Value : public HeapObject {
\
DECLARE_PRINTER(Type) \
\
+ inline bool Equals(Type* that); \
+ \
private: \
DISALLOW_IMPLICIT_CONSTRUCTORS(Type); \
};
« src/api.cc ('K') | « src/mips64/code-stubs-mips64.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698