Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 1298603002: [runtime] Unify and fix the strict equality comparison. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 1443 matching lines...) Expand 10 before | Expand all | Expand 10 after
1454 DCHECK_EQ(1, args.length()); 1454 DCHECK_EQ(1, args.length());
1455 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); 1455 CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
1456 Handle<JSReceiver> receiver; 1456 Handle<JSReceiver> receiver;
1457 if (JSReceiver::ToObject(isolate, object).ToHandle(&receiver)) { 1457 if (JSReceiver::ToObject(isolate, object).ToHandle(&receiver)) {
1458 return *receiver; 1458 return *receiver;
1459 } 1459 }
1460 THROW_NEW_ERROR_RETURN_FAILURE( 1460 THROW_NEW_ERROR_RETURN_FAILURE(
1461 isolate, NewTypeError(MessageTemplate::kUndefinedOrNullToObject)); 1461 isolate, NewTypeError(MessageTemplate::kUndefinedOrNullToObject));
1462 } 1462 }
1463 1463
1464
1465 RUNTIME_FUNCTION(Runtime_StrictEquals) {
1466 SealHandleScope scope(isolate);
1467 DCHECK_EQ(2, args.length());
1468 CONVERT_ARG_CHECKED(Object, x, 0);
1469 CONVERT_ARG_CHECKED(Object, y, 1);
1470 // TODO(bmeurer): Change this at some point to return true/false instead.
1471 return Smi::FromInt(x->StrictEquals(y) ? EQUAL : NOT_EQUAL);
1472 }
1473
1464 } // namespace internal 1474 } // namespace internal
1465 } // namespace v8 1475 } // namespace v8
OLDNEW
« src/api.cc ('K') | « src/runtime/runtime.h ('k') | src/runtime/runtime-simd.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698