Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 1298603002: [runtime] Unify and fix the strict equality comparison. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Unify and fix the strict equality comparison. Add Object::StrictEquals to unify the implementation of strict equality comparison in the runtime and the api (the api was already missing a case for SIMD). Now we (almost) have a single bottleneck for strict equality, we just need to reduce the amount of unnecessary complexity for the code stub. R=yangguo@chromium.org Committed: https://crrev.com/9780ddeb9685c30cf64a337446b9a7413a3be64f Cr-Commit-Position: refs/heads/master@{#30186}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -188 lines) Patch
M src/api.cc View 1 chunk +3 lines, -27 lines 2 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +17 lines, -12 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/objects.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +23 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +20 lines, -16 lines 0 comments Download
M src/runtime.js View 2 chunks +1 line, -20 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-simd.cc View 2 chunks +5 lines, -24 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +16 lines, -11 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +17 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-16 09:28:59 UTC) #1
Benedikt Meurer
Hey Yang, Another useless builtin removed (and another API bug fixed). Please take a look. ...
5 years, 4 months ago (2015-08-16 09:29:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298603002/1
5 years, 4 months ago (2015-08-16 10:54:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-16 10:58:58 UTC) #6
Yang
LGTM. https://codereview.chromium.org/1298603002/diff/1/src/api.cc File src/api.cc (left): https://codereview.chromium.org/1298603002/diff/1/src/api.cc#oldcode3431 src/api.cc:3431: return other->IsUndefined() || other->IsUndetectableObject(); This undetectable check is ...
5 years, 4 months ago (2015-08-17 07:13:32 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/1298603002/diff/1/src/api.cc File src/api.cc (left): https://codereview.chromium.org/1298603002/diff/1/src/api.cc#oldcode3431 src/api.cc:3431: return other->IsUndefined() || other->IsUndetectableObject(); Yes. The code stub has ...
5 years, 4 months ago (2015-08-17 07:59:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298603002/1
5 years, 4 months ago (2015-08-17 08:00:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 08:02:03 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 08:02:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9780ddeb9685c30cf64a337446b9a7413a3be64f
Cr-Commit-Position: refs/heads/master@{#30186}

Powered by Google App Engine
This is Rietveld 408576698