Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3735)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.h

Issue 1298513003: Implemented prototype for new ink drop specs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed concerns from patch set 7. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.h b/chrome/browser/ui/views/toolbar/toolbar_button.h
index c61d85cb07d293772c90469ebdd48de66cf8d1c3..913133f8b6536992dd22f4d349cd7751fdfd76a9 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_BUTTON_H_
#include "base/memory/scoped_ptr.h"
+#include "ui/gfx/geometry/point.h"
#include "ui/views/animation/ink_drop_host.h"
#include "ui/views/context_menu_controller.h"
#include "ui/views/controls/button/button.h"
@@ -68,13 +69,17 @@ class ToolbarButton : public views::LabelButton,
// to the PUSHED state.
bool ShouldEnterPushedState(const ui::Event& event) override;
+ // views::LabelButton:
Peter Kasting 2015/09/09 22:50:46 Nit: I would put this heading over both the overri
bruthig 2015/09/10 14:57:38 Done.
+ void NotifyClick(const ui::Event& event) override;
+
// Returns if menu should be shown. Override this to change default behavior.
virtual bool ShouldShowMenu();
// Function to show the dropdown menu.
virtual void ShowDropDownMenu(ui::MenuSourceType source_type);
- virtual void LayoutInkDrop();
+ // Returns the Point where the ink drop should be centered.
+ virtual gfx::Point CalculateInkDropCenter() const;
views::InkDropAnimationController* ink_drop_animation_controller() {
return ink_drop_animation_controller_.get();

Powered by Google App Engine
This is Rietveld 408576698