Index: chrome/browser/resources/ntp4/new_tab.html |
diff --git a/chrome/browser/resources/ntp4/new_tab.html b/chrome/browser/resources/ntp4/new_tab.html |
index e5bb3e39ecd26dfd23e498238b7fc5a1e048719f..15f591854084d9722c1f37113fbccfd514082c31 100644 |
--- a/chrome/browser/resources/ntp4/new_tab.html |
+++ b/chrome/browser/resources/ntp4/new_tab.html |
@@ -93,6 +93,19 @@ |
</div> |
</div> |
+ <div class="app-launcher-promo" id="app-launcher-promo" hidden> |
arv (Not doing code reviews)
2013/03/26 14:02:39
You should not have both id and class that have th
MAD
2013/03/26 15:42:43
But I need the class for the CSS stuff... no?
And
arv (Not doing code reviews)
2013/03/26 15:53:34
You can use an ID selector in the CSS.
#app-launc
MAD
2013/03/26 17:02:46
Done.
|
+ <div class="apps-promo-text" id="apps-promo-text"> |
arv (Not doing code reviews)
2013/03/25 15:04:38
Why do you need div/div/span? Can one element be u
MAD
2013/03/25 15:32:24
I followed the patterns above...
arv (Not doing code reviews)
2013/03/26 14:02:39
The app-launcher-promo is needed to do the centeri
MAD
2013/03/26 15:42:43
Done.
|
+ <span i18n-content="appsPromoTitle"></span> |
+ </div> |
+ <a href="https://chrome.google.com/webstore/launcher"> |
arv (Not doing code reviews)
2013/03/25 15:04:38
Same here?
MAD
2013/03/25 15:32:24
Done.
|
+ <div class="apps-promo-learn-more" id="apps-promo-learn-more"> |
+ <span i18n-content="learn_more"></span> |
+ </div> |
+ </a> |
+ <img src="app_launcher_promo.png"/> |
arv (Not doing code reviews)
2013/03/25 15:04:38
No /> in HTML
MAD
2013/03/25 15:32:24
Done.
|
+ <div class="close-button" id="app-launcher-promo-close-button"></div> |
arv (Not doing code reviews)
2013/03/25 15:04:38
Should this be a <button>? What is the accessibili
MAD
2013/03/25 15:32:24
Everywhere else I saw the close-button, it was in
arv (Not doing code reviews)
2013/03/26 14:02:39
Really? Look at the #notification above:
<button
MAD
2013/03/26 15:42:43
Ho, sorry, I didn't notice that one... :-/
|
+ </div> |
+ |
<div id="footer"> |
<div id="footer-border"></div> |
<div id="footer-content"> |