Source/core/paint/DeprecatedPaintLayer.cpp - Issue 1298493003: Currently we only composite fixed position elements if we are on High DPI devices. This fix allows …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1298493003: Currently we only composite fixed position elements if we are on High DPI devices. This fix allows … Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update fixed-scroll-in-empty-root-layer Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/compositing/CompositingReasonFinder.cpp ('K') | « Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/DeprecatedPaintLayer.cpp

diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp

index 83f026517b2d4eb8cec6a02dd67551f9d86ada16..60ca9d13640bc453cf00440f74d15de8eec667b9 100644

--- a/Source/core/paint/DeprecatedPaintLayer.cpp

+++ b/Source/core/paint/DeprecatedPaintLayer.cpp

@@ -2329,10 +2329,6 @@ bool DeprecatedPaintLayer::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& l

if (paintsWithFilters() && layoutObject()->style()->filter().hasFilterThatAffectsOpacity())

return false;

- // FIXME: Handle simple transforms.

- if (paintsWithTransform(GlobalPaintNormalPhase))

- return false;

// FIXME: Remove this check.

// This function should not be called when layer-lists are dirty.

// It is somehow getting triggered during style update.