Currently we only composite fixed position elements if we are on High DPI devices. This fix allows …

Source/core/layout/compositing/CompositingReasonFinder.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/layout/compositing/CompositingReasonFinder.h"
 
 #include "core/CSSPropertyNames.h"
 #include "core/dom/Document.h"
 #include "core/frame/FrameView.h"
@@ skipping 158 matching lines @@
 bool CompositingReasonFinder::requiresCompositingForAnimation(const ComputedStyle& style) const
 {
     if (style.subtreeWillChangeContents())
         return style.isRunningAnimationOnCompositor();
 
     return style.shouldCompositeForCurrentAnimations();
 }
 
 bool CompositingReasonFinder::requiresCompositingForPositionFixed(const DeprecatedPaintLayer* layer) const
 {
-    if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger))
-        return false;
     // Don't promote fixed position elements that are descendants of a non-view container, e.g. transformed elements.
     // They will stay fixed wrt the container rather than the enclosing frame.
-    return layer->scrollsWithViewport() && m_layoutView.frameView()->isScrollable();
+    if (!layer->scrollsWithViewport() || !m_layoutView.frameView()->isScrollable())
+        return false;
+
+    if (m_compositingTriggers & ViewportConstrainedPositionedTrigger)
+        return true;
+
+    // If the layer is opaque we can still promote it since we will not lose LCD text
+    LayoutRect bounds = layer->layoutBox()->visualOverflowRect();

[trchen, 2015/08/27 23:10:58]

I looked at the semantics of visualOverflowRect(), it seems that it only
includes the visual overflow from non-stacking-context descendants. (See
LayoutBox::addOverflowFromChild)

I suspect the logic is going to work for this example:
<div style="position:fixed; z-index:0; width:1px; height:1px;
background:white;">
  <div style="position:relative; z-index:0;">
    The text is probably not counted towards visualOverflowRect of the fixed-pos
parent.
  </div>
</div>

This is an awkward situation because in CompositedDeprecatedPaintLayerMapping we
use backgroundIsKnownToBeOpaqueInRect(compositedBounds()) to decide whether a
layer is opaque, but the compositedBounds() (i.e. The union of visual overflow
rect of non-composited descendants.) can't be calculated at this point because
compositing decision hasn't been made yet.

I think the best thing you can do is compute the union of layer bounding box of
all descendant DPLs, ignoring compositing status. You can refer to the code in
DeprecatedPaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().
Perhaps add a enum option to it to ignore compositing status?

[davidfox, 2015/08/30 22:00:04]

Wouldn't it be possible to call DeprecatedPaintLayer::boundingBoxForCompositing
directly?

+    return layer->backgroundIsKnownToBeOpaqueInRect(bounds);
 }
 
 }