Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1298493003: Currently we only composite fixed position elements if we are on High DPI devices. This fix allows … Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update affected tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2311 matching lines...) Expand 10 before | Expand all | Expand 10 after
2322 return false; 2322 return false;
2323 2323
2324 // We can't use hasVisibleContent(), because that will be true if our layout Object is hidden, but some child 2324 // We can't use hasVisibleContent(), because that will be true if our layout Object is hidden, but some child
2325 // is visible and that child doesn't cover the entire rect. 2325 // is visible and that child doesn't cover the entire rect.
2326 if (layoutObject()->style()->visibility() != VISIBLE) 2326 if (layoutObject()->style()->visibility() != VISIBLE)
2327 return false; 2327 return false;
2328 2328
2329 if (paintsWithFilters() && layoutObject()->style()->filter().hasFilterThatAf fectsOpacity()) 2329 if (paintsWithFilters() && layoutObject()->style()->filter().hasFilterThatAf fectsOpacity())
2330 return false; 2330 return false;
2331 2331
2332 // FIXME: Handle simple transforms.
2333 if (paintsWithTransform(GlobalPaintNormalPhase))
2334 return false;
2335
2336 // FIXME: Remove this check. 2332 // FIXME: Remove this check.
2337 // This function should not be called when layer-lists are dirty. 2333 // This function should not be called when layer-lists are dirty.
2338 // It is somehow getting triggered during style update. 2334 // It is somehow getting triggered during style update.
2339 if (m_stackingNode->zOrderListsDirty()) 2335 if (m_stackingNode->zOrderListsDirty())
2340 return false; 2336 return false;
2341 2337
2342 // FIXME: We currently only check the immediate layoutObject, 2338 // FIXME: We currently only check the immediate layoutObject,
2343 // which will miss many cases. 2339 // which will miss many cases.
2344 if (layoutObject()->backgroundIsKnownToBeOpaqueInRect(localRect)) 2340 if (layoutObject()->backgroundIsKnownToBeOpaqueInRect(localRect))
2345 return true; 2341 return true;
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
2671 2667
2672 void showLayerTree(const blink::LayoutObject* layoutObject) 2668 void showLayerTree(const blink::LayoutObject* layoutObject)
2673 { 2669 {
2674 if (!layoutObject) { 2670 if (!layoutObject) {
2675 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2671 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2676 return; 2672 return;
2677 } 2673 }
2678 showLayerTree(layoutObject->enclosingLayer()); 2674 showLayerTree(layoutObject->enclosingLayer());
2679 } 2675 }
2680 #endif 2676 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698