Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1298443002: Fix proc_maps_linux compile for non-Linux (Closed)

Created:
5 years, 4 months ago by Ted Mielczarek
Modified:
5 years, 4 months ago
Reviewers:
ivanpe
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

I'm compiling the processor code with mingw, and the new proc_maps_linux code doesn't build there because it's not including inttypes.h on all platforms. Additionally, I think the toolchain I'm using is being stricter and requires __STDC_FORMAT_MACROS to get the macros we're using out of inttypes.h.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/processor/proc_maps_linux.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ted Mielczarek
5 years, 4 months ago (2015-08-14 14:59:27 UTC) #1
ivanpe
lgtm
5 years, 4 months ago (2015-08-14 21:34:00 UTC) #2
Primiano Tucci (use gerrit)
5 years, 4 months ago (2015-08-18 11:57:08 UTC) #3
Message was sent while issue was closed.
On 2015/08/14 21:34:00, ivanpe wrote:
> lgtm

This doesn't seem to work on Chromne anymore. Errors below. breakpad is now into
an unrollable state.


[60/81] CXX obj/breakpad/libstackwalk_common/proc_maps_linux.o
FAILED: ../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/breakpad/libstackwalk_common/proc_maps_linux.o.d
-DBPLOG_MINIMUM_SEVERITY=SEVERITY_ERROR -DV8_DEPRECATION_WARNINGS
-DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS
-DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA
-DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1
-DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1
-DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1
-DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=242792-1 -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1
-D_GLIBCXX_DEBUG=1 -I.. -Igen -I../breakpad/src -I../breakpad/src/third_party
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -m64
-march=x86-64 -funwind-tables -fPIC -pipe -pthread
-B../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fvisibility=hidden -Xclang -load -Xclang
../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin
-Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O0 -g2
-gsplit-dwarf -Wno-unused-result -Wno-overloaded-virtual -Wno-unused-function
-Wno-unused-variable -Wno-format -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal
-Wno-inconsistent-missing-override -Wno-shift-negative-value
-Wno-tautological-constant-out-of-range-compare -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions
-Wno-deprecated -c ../breakpad/src/processor/proc_maps_linux.cc -o
obj/breakpad/libstackwalk_common/proc_maps_linux.o
../breakpad/src/processor/proc_maps_linux.cc:8:9: error: '__STDC_FORMAT_MACROS'
macro redefined [-Werror,-Wmacro-redefined]
#define __STDC_FORMAT_MACROS 1

Powered by Google App Engine
This is Rietveld 408576698