Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 12984006: Disable zapping of global handles in release mode. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Disable zapping of global handles in release mode. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14028

Patch Set 1 #

Patch Set 2 : Addressed Jakob Kummerow's offline comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M src/global-handles.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-21 14:04:40 UTC) #1
danno
lgtm
7 years, 9 months ago (2013-03-21 14:05:33 UTC) #2
Michael Starzinger
7 years, 9 months ago (2013-03-21 14:18:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698