core/src/fpdftext/fpdf_text_search.cpp - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/fpdf_text_search.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Stray file. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdftext/fpdf_text_search.cpp

diff --git a/core/src/fpdftext/fpdf_text_search.cpp b/core/src/fpdftext/fpdf_text_search.cpp

index 95839b54fbcc450f99db5518bba16f5b8b823fc2..96ab05804f81d2ec599de669e35d6053ef1627b3 100644

--- a/core/src/fpdftext/fpdf_text_search.cpp

+++ b/core/src/fpdftext/fpdf_text_search.cpp

@@ -6,6 +6,8 @@

#include "../../include/fpdfapi/fpdf_pageobj.h"

#include "../../include/fpdfapi/fpdf_page.h"

+#include "text_int.h"

class CPDF_TextStream {

public:

CPDF_TextStream(CFX_WideTextBuf& buffer,