Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Rename, remove dead fn. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/include/fxedit/fx_edit.h ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../public/fpdf_dataavail.h" 7 #include "../../public/fpdf_dataavail.h"
8 #include "../include/fsdk_define.h" 8 #include "../include/fsdk_define.h"
9 9
10 extern void ProcessParseError(FX_DWORD err_code);
11 class CFPDF_FileAvailWrap : public IFX_FileAvail { 10 class CFPDF_FileAvailWrap : public IFX_FileAvail {
12 public: 11 public:
13 CFPDF_FileAvailWrap() { m_pfileAvail = NULL; } 12 CFPDF_FileAvailWrap() { m_pfileAvail = NULL; }
14 ~CFPDF_FileAvailWrap() override {} 13 ~CFPDF_FileAvailWrap() override {}
15 14
16 void Set(FX_FILEAVAIL* pfileAvail) { m_pfileAvail = pfileAvail; } 15 void Set(FX_FILEAVAIL* pfileAvail) { m_pfileAvail = pfileAvail; }
17 16
18 // IFX_FileAvail 17 // IFX_FileAvail
19 FX_BOOL IsDataAvail(FX_FILESIZE offset, FX_DWORD size) override { 18 FX_BOOL IsDataAvail(FX_FILESIZE offset, FX_DWORD size) override {
20 return m_pfileAvail->IsDataAvail(m_pfileAvail, offset, size); 19 return m_pfileAvail->IsDataAvail(m_pfileAvail, offset, size);
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 return -1; 136 return -1;
138 CFPDF_DownloadHintsWrap hints_wrap(hints); 137 CFPDF_DownloadHintsWrap hints_wrap(hints);
139 return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsFormAvail(&hints_wrap); 138 return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsFormAvail(&hints_wrap);
140 } 139 }
141 140
142 DLLEXPORT FPDF_BOOL STDCALL FPDFAvail_IsLinearized(FPDF_AVAIL avail) { 141 DLLEXPORT FPDF_BOOL STDCALL FPDFAvail_IsLinearized(FPDF_AVAIL avail) {
143 if (avail == NULL) 142 if (avail == NULL)
144 return -1; 143 return -1;
145 return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsLinearizedPDF(); 144 return ((CFPDF_DataAvail*)avail)->m_pDataAvail->IsLinearizedPDF();
146 } 145 }
OLDNEW
« no previous file with comments | « fpdfsdk/include/fxedit/fx_edit.h ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698