Extern in .cpp file is a code smell, part 2.

core/src/fxge/ge/fx_ge_fontmap.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <limits>
 
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fxge/fx_freetype.h"
@@ skipping 391 matching lines @@
     {g_FoxitSansBoldFontData, 16344},
     {g_FoxitSansBoldItalicFontData, 16418},
     {g_FoxitSansItalicFontData, 16339},
     {g_FoxitSerifFontData, 19469},
     {g_FoxitSerifBoldFontData, 19395},
     {g_FoxitSerifBoldItalicFontData, 20733},
     {g_FoxitSerifItalicFontData, 21227},
     {g_FoxitSymbolFontData, 16729},
     {g_FoxitDingbatsFontData, 29513},
 };
-void _FPDFAPI_GetInternalFontData(int id,
-                                  const uint8_t*& data,
-                                  FX_DWORD& size) {
-  CFX_GEModule::Get()->GetFontMgr()->GetStandardFont(data, size, id);
-}
 FX_BOOL CFX_FontMgr::GetStandardFont(const uint8_t*& pFontData,
                                      FX_DWORD& size,
                                      int index) {
   if (index > 15 || index < 0) {
     return FALSE;
   }
   {
     if (index >= 14) {
       if (index == 14) {
         pFontData = g_FoxitSerifMMFontData;
@@ skipping 47 matching lines @@
   norm.Remove(' ');
   norm.Remove('-');
   norm.Remove(',');
   int pos = norm.Find('+');
   if (pos > 0) {
     norm = norm.Left(pos);
   }
   norm.MakeLower();
   return norm;
 }
-CFX_ByteString _FPDF_GetNameFromTT(const uint8_t* name_table,
-                                   FX_DWORD name_id) {
+CFX_ByteString FPDF_GetNameFromTT(const uint8_t* name_table, FX_DWORD name_id) {
   const uint8_t* ptr = name_table + 2;
   int name_count = GET_TT_SHORT(ptr);
   int string_offset = GET_TT_SHORT(ptr + 2);
   const uint8_t* string_ptr = name_table + string_offset;
   ptr += 4;
   for (int i = 0; i < name_count; i++) {
     if (GET_TT_SHORT(ptr + 6) == name_id && GET_TT_SHORT(ptr) == 1 &&
         GET_TT_SHORT(ptr + 2) == 0) {
       return CFX_ByteStringC(string_ptr + GET_TT_SHORT(ptr + 10),
                              GET_TT_SHORT(ptr + 8));
@@ skipping 47 matching lines @@
 }
 CFX_ByteString CFX_FontMapper::GetPSNameFromTT(void* hFont) {
   if (m_pFontInfo == NULL) {
     CFX_ByteString();
   }
   CFX_ByteString result;
   FX_DWORD size = m_pFontInfo->GetFontData(hFont, 0x6e616d65, NULL, 0);
   if (size) {
     uint8_t* buffer = FX_Alloc(uint8_t, size);
     m_pFontInfo->GetFontData(hFont, 0x6e616d65, buffer, size);
-    result = _FPDF_GetNameFromTT(buffer, 6);
+    result = FPDF_GetNameFromTT(buffer, 6);
     FX_Free(buffer);
   }
   return result;
 }
 void CFX_FontMapper::AddInstalledFont(const CFX_ByteString& name, int charset) {
   if (m_pFontInfo == NULL) {
     return;
   }
   if (m_CharsetArray.Find((FX_DWORD)charset) == -1) {
     m_CharsetArray.Add((FX_DWORD)charset);
@@ skipping 678 matching lines @@
   m_Weight = 0;
   m_bItalic = FALSE;
   m_PitchFamily = 0;
 }
 CFontFileFaceInfo::~CFontFileFaceInfo() {
   if (m_Face) {
     FXFT_Done_Face(m_Face);
   }
   m_Face = NULL;
 }
-extern FX_BOOL _LoadFile(FXFT_Library library,
-                         FXFT_Face* Face,
-                         IFX_FileRead* pFile,
-                         FXFT_Stream* stream);
 #if _FX_OS_ == _FX_ANDROID_
 IFX_SystemFontInfo* IFX_SystemFontInfo::CreateDefault(const char** pUnused) {
   return NULL;
 }
 #endif
 CFX_FolderFontInfo::CFX_FolderFontInfo() {}
 CFX_FolderFontInfo::~CFX_FolderFontInfo() {
   for (const auto& pair : m_FontList) {
     delete pair.second;
   }
@@ skipping 93 matching lines @@
   if (!FXSYS_fread(buffer, 12, 1, pFile)) {
     return;
   }
   FX_DWORD nTables = GET_TT_SHORT(buffer + 4);
   CFX_ByteString tables = _FPDF_ReadStringFromFile(pFile, nTables * 16);
   if (tables.IsEmpty()) {
     return;
   }
   CFX_ByteString names =
       _FPDF_LoadTableFromTT(pFile, tables, nTables, 0x6e616d65);
-  CFX_ByteString facename = _FPDF_GetNameFromTT(names, 1);
-  CFX_ByteString style = _FPDF_GetNameFromTT(names, 2);
+  CFX_ByteString facename = FPDF_GetNameFromTT(names, 1);
+  CFX_ByteString style = FPDF_GetNameFromTT(names, 2);
   if (style != "Regular") {
     facename += " " + style;
   }
   if (m_FontList.find(facename) != m_FontList.end()) {
     return;
   }
   CFX_FontFaceInfo* pInfo =
       new CFX_FontFaceInfo(path, facename, tables, offset, filesize);
   CFX_ByteString os2 =
       _FPDF_LoadTableFromTT(pFile, tables, nTables, 0x4f532f32);
@@ skipping 95 matching lines @@
   if (hFont == NULL) {
     return FALSE;
   }
   CFX_FontFaceInfo* pFont = (CFX_FontFaceInfo*)hFont;
   name = pFont->m_FaceName;
   return TRUE;
 }
 FX_BOOL CFX_FolderFontInfo::GetFontCharset(void* hFont, int& charset) {
   return FALSE;
 }