Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: core/src/fxge/dib/fx_dib_main.cpp

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Stray file. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fxge/fx_dib.h" 7 #include "../../../include/fxge/fx_dib.h"
8 #include "../../../include/fxge/fx_ge.h" 8 #include "../../../include/fxge/fx_ge.h"
9 #include "../../../include/fxcodec/fx_codec.h" 9 #include "../../../include/fxcodec/fx_codec.h"
10 #include "dib_int.h" 10 #include "dib_int.h"
(...skipping 1533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1544 } 1544 }
1545 CFX_ImageRenderer::CFX_ImageRenderer() { 1545 CFX_ImageRenderer::CFX_ImageRenderer() {
1546 m_Status = 0; 1546 m_Status = 0;
1547 m_pTransformer = NULL; 1547 m_pTransformer = NULL;
1548 m_bRgbByteOrder = FALSE; 1548 m_bRgbByteOrder = FALSE;
1549 m_BlendType = FXDIB_BLEND_NORMAL; 1549 m_BlendType = FXDIB_BLEND_NORMAL;
1550 } 1550 }
1551 CFX_ImageRenderer::~CFX_ImageRenderer() { 1551 CFX_ImageRenderer::~CFX_ImageRenderer() {
1552 delete m_pTransformer; 1552 delete m_pTransformer;
1553 } 1553 }
1554 extern FX_RECT _FXDIB_SwapClipBox(FX_RECT& clip,
1555 int width,
1556 int height,
1557 FX_BOOL bFlipX,
1558 FX_BOOL bFlipY);
1559 FX_BOOL CFX_ImageRenderer::Start(CFX_DIBitmap* pDevice, 1554 FX_BOOL CFX_ImageRenderer::Start(CFX_DIBitmap* pDevice,
1560 const CFX_ClipRgn* pClipRgn, 1555 const CFX_ClipRgn* pClipRgn,
1561 const CFX_DIBSource* pSource, 1556 const CFX_DIBSource* pSource,
1562 int bitmap_alpha, 1557 int bitmap_alpha,
1563 FX_DWORD mask_color, 1558 FX_DWORD mask_color,
1564 const CFX_AffineMatrix* pMatrix, 1559 const CFX_AffineMatrix* pMatrix,
1565 FX_DWORD dib_flags, 1560 FX_DWORD dib_flags,
1566 FX_BOOL bRgbByteOrder, 1561 FX_BOOL bRgbByteOrder,
1567 int alpha_flag, 1562 int alpha_flag,
1568 void* pIccTransform, 1563 void* pIccTransform,
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 if (!m_pBitmap->Create(width, height, src_format)) { 1713 if (!m_pBitmap->Create(width, height, src_format)) {
1719 delete m_pBitmap; 1714 delete m_pBitmap;
1720 m_pBitmap = NULL; 1715 m_pBitmap = NULL;
1721 return FALSE; 1716 return FALSE;
1722 } 1717 }
1723 if (pSrcPalette) { 1718 if (pSrcPalette) {
1724 m_pBitmap->CopyPalette(pSrcPalette); 1719 m_pBitmap->CopyPalette(pSrcPalette);
1725 } 1720 }
1726 return TRUE; 1721 return TRUE;
1727 } 1722 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698