core/include/fpdfapi/fpdf_render.h - Issue 1298393003: Extern in .cpp file is a code smell, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/include/fpdfapi/fpdf_render.h

Issue 1298393003: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Stray file. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_	7 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_

8 #define CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_	8 #define CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_

9	9

10 #include "../../../third_party/base/nonstd_unique_ptr.h"	10 #include "../../../third_party/base/nonstd_unique_ptr.h"

(...skipping 270 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
281 FX_BOOL m_bCurFindCache;	281 FX_BOOL m_bCurFindCache;

282 };	282 };

283 class CPDF_RenderConfig {	283 class CPDF_RenderConfig {

284 public:	284 public:

285 CPDF_RenderConfig();	285 CPDF_RenderConfig();

286 ~CPDF_RenderConfig();	286 ~CPDF_RenderConfig();

287 int m_HalftoneLimit;	287 int m_HalftoneLimit;

288 int m_RenderStepLimit;	288 int m_RenderStepLimit;

289 };	289 };

290	290

	291 FX_BOOL IsAvailableMatrix(const CFX_AffineMatrix& matrix);

	292

291 #endif // CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_	293 #endif // CORE_INCLUDE_FPDFAPI_FPDF_RENDER_H_

OLD	NEW