Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298373005: DevTools: inline some private methods that called only once (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: inline some private methods that called only once * Inlined clear() and disable() methods * Inlined promiseTracker() getter * Disable PromiseTracker when disabling debugger instead of simply clearing the former BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -50 lines) Patch
M Source/core/inspector/V8DebuggerAgent.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/inspector/V8DebuggerAgent.cpp View 8 chunks +38 lines, -47 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yurys
5 years, 4 months ago (2015-08-20 02:22:05 UTC) #2
dgozman
lgtm
5 years, 4 months ago (2015-08-20 02:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298373005/1
5 years, 4 months ago (2015-08-20 02:27:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/22045)
5 years, 4 months ago (2015-08-20 03:07:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298373005/1
5 years, 4 months ago (2015-08-20 04:49:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110816) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-20 05:10:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298373005/1
5 years, 4 months ago (2015-08-20 14:50:28 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 15:10:23 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200905

Powered by Google App Engine
This is Rietveld 408576698