Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 129833002: Add getUserMedia info to the dump and add browser tests. (Closed)

Created:
6 years, 11 months ago by jiayl
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add getUserMedia info to the dump and add browser tests. BUG=304023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244281

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -4 lines) Patch
M content/browser/media/webrtc_internals_browsertest.cc View 4 chunks +96 lines, -0 lines 0 comments Download
M content/browser/resources/media/dump_creator.js View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M content/browser/resources/media/webrtc_internals.js View 1 2 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jiayl
This will help debugging getUserMedia issues. PTAL. Thanks!
6 years, 11 months ago (2014-01-08 23:39:55 UTC) #1
vrk (LEFT CHROMIUM)
lgtm https://codereview.chromium.org/129833002/diff/1/content/browser/resources/media/webrtc_internals.js File content/browser/resources/media/webrtc_internals.js (right): https://codereview.chromium.org/129833002/diff/1/content/browser/resources/media/webrtc_internals.js#newcode256 content/browser/resources/media/webrtc_internals.js:256: // TODO(jiayl): add the getUserMedia info to the ...
6 years, 11 months ago (2014-01-09 00:26:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/129833002/60001
6 years, 11 months ago (2014-01-10 19:21:52 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/browser/resources/media/dump_creator.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-10 19:21:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/129833002/100001
6 years, 11 months ago (2014-01-10 19:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/129833002/100001
6 years, 11 months ago (2014-01-10 23:23:08 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 00:12:32 UTC) #7
Message was sent while issue was closed.
Change committed as 244281

Powered by Google App Engine
This is Rietveld 408576698